mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-09-03 02:03:48 +00:00
Code Issues Projects Releases Wiki Activity

meson, cargo: don't build skia plugin by default for now

Browse source 
Fails to build in some/many cases:

https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/692
https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1804

In addition to the git-sync-deps issue, the skia-safe project uses
cargo to invoke gn, and in the process it loses the ability to pick up
dependencies from the system. This means it cannot integrate as
a meson subproject.

Co-authored-by: L. E. Segovia <amy@amyspark.me>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2251>
This commit is contained in:
Nirbheek Chauhan 2025-05-20 16:48:18 +05:30 committed by GStreamer Marge Bot
parent a19c9229d8
commit 850b566b1b
4 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Cargo.toml
View file

@ -117,7 +117,6 @@ default-members = [
"video/hsv", "video/hsv",
"video/png", "video/png",
"video/rav1e", "video/rav1e",
"video/skia",
] ]
[profile.release] [profile.release]

4
ci/utils.py
View file

@ -1,4 +1,5 @@
import os import os
from warnings import warn
DIRS = [ DIRS = [
'audio', 'audio',
@ -37,6 +38,9 @@ OVERRIDE = {
def iterate_plugins(): def iterate_plugins():
for d in DIRS: for d in DIRS:
for name in os.listdir(d): for name in os.listdir(d):
if 'skia' in name:
warn('Skipping skia, see https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/692')
continue
if name in RS_PREFIXED: if name in RS_PREFIXED:
name = "rs{}".format(name) name = "rs{}".format(name)
else: else:

7
meson.build
View file

@ -222,7 +222,6 @@ plugins = {
'quic_roq', 'quic_roq',
], ],
}, },
'skia': {'library': 'libgstskia'},
'speechmatics': {'library': 'libgstspeechmatics'}, 'speechmatics': {'library': 'libgstspeechmatics'},
'vvdec': { 'vvdec': {
'library': 'libgstvvdec', 'library': 'libgstvvdec',
@ -351,6 +350,12 @@ else
} }
endif endif
if get_option('skia').allowed()
plugins += {
'skia': {'library': 'libgstskia'},
}
endif
# Process plugins list # Process plugins list
default_library = get_option('default_library') default_library = get_option('default_library')

2
meson_options.txt
View file

@ -66,7 +66,7 @@ option('gtk4', type: 'feature', value: 'auto', description: 'Build GTK4 plugin')
option('hsv', type: 'feature', value: 'auto', description: 'Build hsv plugin') option('hsv', type: 'feature', value: 'auto', description: 'Build hsv plugin')
option('png', type: 'feature', value: 'auto', description: 'Build png plugin') option('png', type: 'feature', value: 'auto', description: 'Build png plugin')
option('rav1e', type: 'feature', value: 'auto', description: 'Build rav1e plugin') option('rav1e', type: 'feature', value: 'auto', description: 'Build rav1e plugin')
option('skia', type: 'feature', value: 'auto', description: 'Build skia plugin') option('skia', type: 'feature', value: 'disabled', description: 'Build skia plugin')
option('videofx', type: 'feature', value: 'auto', description: 'Build videofx plugin') option('videofx', type: 'feature', value: 'auto', description: 'Build videofx plugin')
option('vvdec', type: 'feature', value: 'auto', description: 'Build vvdec plugin') option('vvdec', type: 'feature', value: 'auto', description: 'Build vvdec plugin')
option('webp', type: 'feature', value: 'auto', description: 'Build webp plugin') option('webp', type: 'feature', value: 'auto', description: 'Build webp plugin')