mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-12-20 00:56:30 +00:00
Code Issues Projects Releases Wiki Activity

fmp4mux: Drop gap buffers before further processing

Browse source 
They would potentially change timestamps and will break in ONVIF mode.
This commit is contained in:
Sebastian Dröge 2022-09-15 18:11:10 +03:00
parent 1fa39d0ab4
commit 7e13ea4ba9
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
generic/fmp4/src/fmp4mux/imp.rs
View file

@ -889,6 +889,15 @@ impl FMP4Mux {
} }
} }
// Remove all GAP buffers before processing them further
for buffers in &mut drain_buffers {
buffers.retain(|buf| {
!buf.buffer.flags().contains(gst::BufferFlags::GAP)
|| !buf.buffer.flags().contains(gst::BufferFlags::DROPPABLE)
|| buf.buffer.size() != 0
});
}
let mut max_end_utc_time = None; let mut max_end_utc_time = None;
// For ONVIF, replace all timestamps with timestamps based on UTC times. // For ONVIF, replace all timestamps with timestamps based on UTC times.
if class.as_ref().variant == super::Variant::ONVIF { if class.as_ref().variant == super::Variant::ONVIF {
@ -1196,13 +1205,6 @@ impl FMP4Mux {
if interleaved_buffers.is_empty() { if interleaved_buffers.is_empty() {
assert!(timeout || at_eos); assert!(timeout || at_eos);
} else { } else {
// Remove all GAP buffers before writing them out
interleaved_buffers.retain(|buf| {
!buf.buffer.flags().contains(gst::BufferFlags::GAP)
|| !buf.buffer.flags().contains(gst::BufferFlags::DROPPABLE)
|| buf.buffer.size() != 0
});
let min_earliest_pts_position = min_earliest_pts_position.unwrap(); let min_earliest_pts_position = min_earliest_pts_position.unwrap();
let min_earliest_pts = min_earliest_pts.unwrap(); let min_earliest_pts = min_earliest_pts.unwrap();
let max_end_pts = max_end_pts.unwrap(); let max_end_pts = max_end_pts.unwrap();