mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-02-02 06:02:20 +00:00
Code Issues Projects Releases Wiki Activity

net/webrtcsink: drop State lock before calling set-local-description

Browse source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1325>
This commit is contained in:
François Laignel 2023-09-18 17:01:07 +02:00 committed by GStreamer Marge Bot
parent c021e2b69f
commit 785c9557c8
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
net/webrtc/src/webrtcsink/imp.rs
View file

@ -1839,12 +1839,13 @@ impl BaseWebRTCSink {
.and_then(|format| format.parse::<i32>().ok()); .and_then(|format| format.parse::<i32>().ok());
} }
// FIXME I think the intention was to drop(state) and re-acquire the lock after the call drop(state);
session session
.webrtcbin .webrtcbin
.emit_by_name::<()>("set-local-description", &[&answer, &None::<gst::Promise>]); .emit_by_name::<()>("set-local-description", &[&answer, &None::<gst::Promise>]);
let mut state = self.state.lock().unwrap();
let session_id = session.id.clone(); let session_id = session.id.clone();
if let Some(session_wrapper) = state.sessions.get_mut(&session_id) { if let Some(session_wrapper) = state.sessions.get_mut(&session_id) {