mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-24 20:41:00 +00:00
Code Issues Projects Releases Wiki Activity

fallbacksrc: Don't check caps when linking to the fallbackswitch

Browse source 
Downstream might have different caps requirements and linking might
fail. Instead of having linking fail, give upstream an opportunity to
reconfigure and otherwise have a normal negotiation error during data
flow.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/334

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1156>
This commit is contained in:
Sebastian Dröge 2023-04-04 12:34:27 +03:00 committed by GStreamer Marge Bot
parent 138c318be6
commit 722dba1203
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
utils/fallbackswitch/src/fallbacksrc/imp.rs
View file

@ -1178,8 +1178,13 @@ impl FallbackSrc {
let dummy_srcpad = dummy_source.static_pad("src").unwrap();
let dummy_sinkpad = switch.request_pad_simple("sink_%u").unwrap();
dummy_srcpad.link(&dummy_sinkpad).unwrap();
dummy_sinkpad.set_property("priority", 2u32);
dummy_srcpad
.link_full(
&dummy_sinkpad,
gst::PadLinkCheck::all() & !gst::PadLinkCheck::CAPS,
)
.unwrap();
switch.connect_notify(Some("active-pad"), move |switch, _pspec| {
let element = match switch
@ -1894,7 +1899,12 @@ impl FallbackSrc {
// Link the new source pad in
let switch_pad = switch.request_pad_simple("sink_%u").unwrap();
switch_pad.set_property("priority", u32::from(fallback_source));
ghostpad.link(&switch_pad).unwrap();
ghostpad
.link_full(
&switch_pad,
gst::PadLinkCheck::all() & !gst::PadLinkCheck::CAPS,
)
.unwrap();
pad.add_probe(gst::PadProbeType::EVENT_DOWNSTREAM, move |pad, info| {
let element = match pad