mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-22 19:41:00 +00:00
Code Issues Projects Releases Wiki Activity

rtpgccbwe: Don't process empty lists

Browse source 
The structure parsing could result in an empty vector. Don't do any processing
since the loss code assumes it's non-empty for average estimates which would
result in weird/invalid results.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1181>
This commit is contained in:
Edward Hervey 2023-04-15 08:17:09 +02:00 committed by Edward Hervey
parent dbdb9bc164
commit 721d17e181
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
net/rtp/src/gcc/imp.rs
View file

@ -1184,19 +1184,22 @@ impl ObjectSubclass for BandwidthEstimator {
})
.collect::<Vec<Packet>>();
let bitrate_changed = {
let mut state = this.state.lock().unwrap();
// The list of packets could be empty once parsed
if !packets.is_empty() {
let bitrate_changed = {
let mut state = this.state.lock().unwrap();
state.detector.update(&mut packets);
if !state.delay_control(&bwe) {
state.loss_control(&bwe)
} else {
true
state.detector.update(&mut packets);
if !state.delay_control(&bwe) {
state.loss_control(&bwe)
} else {
true
}
};
if bitrate_changed {
bwe.notify("estimated-bitrate")
}
};
if bitrate_changed {
bwe.notify("estimated-bitrate")
}
}
}