mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-26 21:41:03 +00:00
Code Issues Projects Releases Wiki Activity

dav1ddec: Update for fixed dav1d-rs API

Browse source 
As a side effect this allows us also to handle errors more gracefully
and to reduce memory load by outputting decoded frames immediately.

Also the code was changed a bit to reduce the number of redundant mutex
lock/unlocks.
This commit is contained in:
Sebastian Dröge 2022-02-02 16:26:31 +02:00 committed by Sebastian Dröge
parent b795c0c392
commit 6ce3029e07
2 changed files with 187 additions and 89 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
video/dav1d/Cargo.toml
View file

@ -9,7 +9,8 @@ license = "MIT/Apache-2.0"
description = "Dav1d Plugin" description = "Dav1d Plugin"
[dependencies] [dependencies]
dav1d = "0.6" # dav1d = "0.7"
dav1d = { git = "https://github.com/rust-av/dav1d-rs" }
gst = { package = "gstreamer", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs" } gst = { package = "gstreamer", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs" }
gst-base = { package = "gstreamer-base", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs" } gst-base = { package = "gstreamer-base", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs" }
gst-video = { package = "gstreamer-video", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs", features = ["v1_12"] } gst-video = { package = "gstreamer-video", git = "https://gitlab.freedesktop.org/gstreamer/gstreamer-rs", features = ["v1_12"] }

255
video/dav1d/src/dav1ddec/imp.rs
View file

@ -18,7 +18,7 @@ use gst_video::subclass::prelude::*;
use once_cell::sync::Lazy; use once_cell::sync::Lazy;
use std::i32; use std::i32;
use std::sync::Mutex; use std::sync::{Mutex, MutexGuard};
#[derive(Default)] #[derive(Default)]
struct State { struct State {
@ -43,7 +43,7 @@ static CAT: Lazy<gst::DebugCategory> = Lazy::new(|| {
}); });
impl Dav1dDec { impl Dav1dDec {
pub fn gst_video_format_from_dav1d_picture( fn gst_video_format_from_dav1d_picture(
&self, &self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
pic: &dav1d::Picture, pic: &dav1d::Picture,
@ -87,16 +87,20 @@ impl Dav1dDec {
}) })
} }
pub fn handle_resolution_change( fn handle_resolution_change<'s>(
&self, &'s self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
mut state_guard: MutexGuard<'s, Option<State>>,
pic: &dav1d::Picture, pic: &dav1d::Picture,
format: gst_video::VideoFormat, ) -> Result<MutexGuard<'s, Option<State>>, gst::FlowError> {
) -> Result<(), gst::FlowError> {
let mut state_guard = self.state.lock().unwrap();
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
let negotiate = { let format = self.gst_video_format_from_dav1d_picture(element, pic);
if format == gst_video::VideoFormat::Unknown {
return Err(gst::FlowError::NotNegotiated);
}
let need_negotiate = {
match state.output_info { match state.output_info {
Some(ref i) => { Some(ref i) => {
(i.width() != pic.width()) (i.width() != pic.width())
@ -105,13 +109,15 @@ impl Dav1dDec {
None => true, None => true,
} }
}; };
if !negotiate { if !need_negotiate {
return Ok(()); return Ok(state_guard);
} }
gst_info!( gst_info!(
CAT, CAT,
obj: element, obj: element,
"Negotiating format picture dimensions {}x{}", "Negotiating format {:?} picture dimensions {}x{}",
format,
pic.width(), pic.width(),
pic.height() pic.height()
); );
@ -124,68 +130,105 @@ impl Dav1dDec {
element.negotiate(output_state)?; element.negotiate(output_state)?;
let out_state = element.output_state().unwrap(); let out_state = element.output_state().unwrap();
let mut state_guard = self.state.lock().unwrap(); state_guard = self.state.lock().unwrap();
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
state.output_info = Some(out_state.info()); state.output_info = Some(out_state.info());
Ok(()) Ok(state_guard)
} }
fn flush_decoder(&self, _element: &super::Dav1dDec) { fn flush_decoder(&self, element: &super::Dav1dDec, state_guard: &mut Option<State>) {
let mut state_guard = self.state.lock().unwrap(); gst_info!(CAT, obj: element, "Flushing decoder");
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
state.decoder.flush(); state.decoder.flush();
} }
fn decode( fn send_data(
&self, &self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
input_buffer: &gst::BufferRef, state_guard: &mut MutexGuard<Option<State>>,
input_buffer: gst::Buffer,
frame: &gst_video::VideoCodecFrame, frame: &gst_video::VideoCodecFrame,
) -> Result<Vec<(dav1d::Picture, gst_video::VideoFormat)>, gst::FlowError> { ) -> Result<std::ops::ControlFlow<(), ()>, gst::FlowError> {
let mut state_guard = self.state.lock().unwrap(); gst_trace!(
CAT,
obj: element,
"Sending data to decoder for frame {}",
frame.system_frame_number()
);
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
let timestamp = frame.dts().map(|ts| *ts as i64); let timestamp = frame.dts().map(|ts| *ts as i64);
let duration = frame.duration().map(|d| *d as i64); let duration = frame.duration().map(|d| *d as i64);
let frame_number = Some(frame.system_frame_number() as i64); let frame_number = Some(frame.system_frame_number() as i64);
let input_data = input_buffer let input_data = input_buffer
.map_readable() .into_mapped_buffer_readable()
.map_err(|_| gst::FlowError::Error)?; .map_err(|_| gst::FlowError::Error)?;
let pictures =
match state match state
.decoder .decoder
.decode(input_data, frame_number, timestamp, duration, || {}) .send_data(input_data, frame_number, timestamp, duration)
{ {
Ok(pictures) => pictures, Ok(()) => {
gst_trace!(CAT, obj: element, "Decoder returned OK");
Ok(std::ops::ControlFlow::Break(()))
}
Err(err) if err.is_again() => {
gst_trace!(CAT, obj: element, "Decoder returned EAGAIN");
Ok(std::ops::ControlFlow::Continue(()))
}
Err(err) => { Err(err) => {
gst_error!(CAT, "Decoding failed (error code: {})", err); gst_error!(CAT, "Sending data failed (error code: {})", err);
return gst_video::video_decoder_error!( return gst_video::video_decoder_error!(
element, element,
1, 1,
gst::StreamError::Decode, gst::StreamError::Decode,
["Decoding failed (error code {})", err] ["Sending data failed (error code {})", err]
) )
.map(|_| vec![]); .map(|_| std::ops::ControlFlow::Break(()));
}
};
let mut decoded_pictures = vec![];
for pic in pictures {
let format = self.gst_video_format_from_dav1d_picture(element, &pic);
if format != gst_video::VideoFormat::Unknown {
decoded_pictures.push((pic, format));
} else {
return Err(gst::FlowError::NotNegotiated);
} }
} }
Ok(decoded_pictures)
} }
pub fn decoded_picture_as_buffer( fn send_pending_data(
&self, &self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
state_guard: &mut MutexGuard<Option<State>>,
) -> Result<std::ops::ControlFlow<(), ()>, gst::FlowError> {
gst_trace!(CAT, obj: element, "Sending pending data to decoder");
let state = state_guard.as_mut().unwrap();
match state.decoder.send_pending_data() {
Ok(()) => {
gst_trace!(CAT, obj: element, "Decoder returned OK");
Ok(std::ops::ControlFlow::Break(()))
}
Err(err) if err.is_again() => {
gst_trace!(CAT, obj: element, "Decoder returned EAGAIN");
Ok(std::ops::ControlFlow::Continue(()))
}
Err(err) => {
gst_error!(CAT, "Sending data failed (error code: {})", err);
return gst_video::video_decoder_error!(
element,
1,
gst::StreamError::Decode,
["Sending data failed (error code {})", err]
)
.map(|_| std::ops::ControlFlow::Break(()));
}
}
}
fn decoded_picture_as_buffer(
&self,
element: &super::Dav1dDec,
state_guard: &mut MutexGuard<Option<State>>,
pic: &dav1d::Picture, pic: &dav1d::Picture,
output_state: gst_video::VideoCodecState<gst_video::video_codec_state::Readable>, output_state: gst_video::VideoCodecState<gst_video::video_codec_state::Readable>,
) -> Result<gst::Buffer, gst::FlowError> { ) -> Result<gst::Buffer, gst::FlowError> {
@ -193,10 +236,8 @@ impl Dav1dDec {
let mut strides = vec![]; let mut strides = vec![];
let mut acc_offset: usize = 0; let mut acc_offset: usize = 0;
let mut state_guard = self.state.lock().unwrap();
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
let video_meta_supported = state.video_meta_supported; let video_meta_supported = state.video_meta_supported;
drop(state_guard);
let info = output_state.info(); let info = output_state.info();
let mut out_buffer = gst::Buffer::new(); let mut out_buffer = gst::Buffer::new();
@ -268,38 +309,41 @@ impl Dav1dDec {
.unwrap() .unwrap()
.set_duration(gst::ClockTime::from_nseconds(duration)); .set_duration(gst::ClockTime::from_nseconds(duration));
} }
Ok(out_buffer) Ok(out_buffer)
} }
fn handle_picture( fn handle_picture<'s>(
&self, &'s self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
mut state_guard: MutexGuard<'s, Option<State>>,
pic: &dav1d::Picture, pic: &dav1d::Picture,
format: gst_video::VideoFormat, ) -> Result<MutexGuard<'s, Option<State>>, gst::FlowError> {
) -> Result<gst::FlowSuccess, gst::FlowError> { gst_trace!(CAT, obj: element, "Handling picture {}", pic.offset());
self.handle_resolution_change(element, pic, format)?;
state_guard = self.handle_resolution_change(element, state_guard, pic)?;
let output_state = element let output_state = element
.output_state() .output_state()
.expect("Output state not set. Shouldn't happen!"); .expect("Output state not set. Shouldn't happen!");
let offset = pic.offset() as i32; let offset = pic.offset() as i32;
if let Some(mut frame) = element.frame(offset) { if let Some(mut frame) = element.frame(offset) {
let output_buffer = self.decoded_picture_as_buffer(element, pic, output_state)?; let output_buffer =
self.decoded_picture_as_buffer(element, &mut state_guard, pic, output_state)?;
frame.set_output_buffer(output_buffer); frame.set_output_buffer(output_buffer);
drop(state_guard);
element.finish_frame(frame)?; element.finish_frame(frame)?;
Ok(self.state.lock().unwrap())
} else { } else {
gst_warning!(CAT, obj: element, "No frame found for offset {}", offset); gst_warning!(CAT, obj: element, "No frame found for offset {}", offset);
Ok(state_guard)
}
} }
self.forward_pending_pictures(element) fn drop_decoded_pictures(&self, element: &super::Dav1dDec, state_guard: &mut Option<State>) {
} while let Ok(Some(pic)) = self.pending_pictures(element, state_guard) {
gst_debug!(CAT, obj: element, "Dropping picture {}", pic.offset());
fn drop_decoded_pictures(&self, element: &super::Dav1dDec) {
let mut state_guard = self.state.lock().unwrap();
let state = state_guard.as_mut().unwrap();
while let Ok(pic) = state.decoder.get_picture() {
gst_debug!(CAT, obj: element, "Dropping picture");
drop(pic); drop(pic);
} }
} }
@ -307,29 +351,50 @@ impl Dav1dDec {
fn pending_pictures( fn pending_pictures(
&self, &self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
) -> Result<Vec<(dav1d::Picture, gst_video::VideoFormat)>, gst::FlowError> { state_guard: &mut Option<State>,
let mut state_guard = self.state.lock().unwrap(); ) -> Result<Option<dav1d::Picture>, gst::FlowError> {
gst_trace!(CAT, obj: element, "Retrieving pending picture");
let state = state_guard.as_mut().unwrap(); let state = state_guard.as_mut().unwrap();
let mut pictures = vec![]; match state.decoder.get_picture() {
while let Ok(pic) = state.decoder.get_picture() { Ok(pic) => {
let format = self.gst_video_format_from_dav1d_picture(element, &pic); gst_trace!(CAT, obj: element, "Retrieved picture {}", pic.offset());
if format == gst_video::VideoFormat::Unknown { Ok(Some(pic))
return Err(gst::FlowError::NotNegotiated); }
Err(err) if err.is_again() => {
gst_trace!(CAT, obj: element, "Decoder needs more data");
Ok(None)
}
Err(err) => {
gst_error!(
CAT,
obj: element,
"Retrieving decoded picture failed (error code {})",
err
);
gst_video::video_decoder_error!(
element,
1,
gst::StreamError::Decode,
["Retrieving decoded picture failed (error code {})", err]
)
.map(|_| None)
} }
pictures.push((pic, format));
} }
Ok(pictures)
} }
fn forward_pending_pictures( fn forward_pending_pictures<'s>(
&self, &'s self,
element: &super::Dav1dDec, element: &super::Dav1dDec,
) -> Result<gst::FlowSuccess, gst::FlowError> { mut state_guard: MutexGuard<'s, Option<State>>,
for (pic, format) in self.pending_pictures(element)? { ) -> Result<MutexGuard<Option<State>>, gst::FlowError> {
self.handle_picture(element, &pic, format)?; while let Some(pic) = self.pending_pictures(element, &mut state_guard)? {
state_guard = self.handle_picture(element, state_guard, &pic)?;
} }
Ok(gst::FlowSuccess::Ok)
Ok(state_guard)
} }
} }
@ -475,9 +540,26 @@ impl VideoDecoderImpl for Dav1dDec {
element: &Self::Type, element: &Self::Type,
frame: gst_video::VideoCodecFrame, frame: gst_video::VideoCodecFrame,
) -> Result<gst::FlowSuccess, gst::FlowError> { ) -> Result<gst::FlowSuccess, gst::FlowError> {
let input_buffer = frame.input_buffer().expect("frame without input buffer"); let input_buffer = frame
for (pic, format) in self.decode(element, input_buffer, &frame)? { .input_buffer_owned()
self.handle_picture(element, &pic, format)?; .expect("frame without input buffer");
{
let mut state_guard = self.state.lock().unwrap();
state_guard = self.forward_pending_pictures(element, state_guard)?;
if self.send_data(element, &mut state_guard, input_buffer, &frame)?
== std::ops::ControlFlow::Continue(())
{
loop {
state_guard = self.forward_pending_pictures(element, state_guard)?;
if self.send_pending_data(element, &mut state_guard)?
== std::ops::ControlFlow::Break(())
{
break;
}
}
}
let _state_guard = self.forward_pending_pictures(element, state_guard)?;
} }
Ok(gst::FlowSuccess::Ok) Ok(gst::FlowSuccess::Ok)
@ -485,22 +567,37 @@ impl VideoDecoderImpl for Dav1dDec {
fn flush(&self, element: &Self::Type) -> bool { fn flush(&self, element: &Self::Type) -> bool {
gst_info!(CAT, obj: element, "Flushing"); gst_info!(CAT, obj: element, "Flushing");
self.flush_decoder(element);
self.drop_decoded_pictures(element); {
let mut state_guard = self.state.lock().unwrap();
self.flush_decoder(element, &mut state_guard);
self.drop_decoded_pictures(element, &mut state_guard);
}
true true
} }
fn drain(&self, element: &Self::Type) -> Result<gst::FlowSuccess, gst::FlowError> { fn drain(&self, element: &Self::Type) -> Result<gst::FlowSuccess, gst::FlowError> {
gst_info!(CAT, obj: element, "Draining"); gst_info!(CAT, obj: element, "Draining");
self.flush_decoder(element);
self.forward_pending_pictures(element)?; {
let mut state_guard = self.state.lock().unwrap();
self.flush_decoder(element, &mut state_guard);
let _state_guard = self.forward_pending_pictures(element, state_guard)?;
}
self.parent_drain(element) self.parent_drain(element)
} }
fn finish(&self, element: &Self::Type) -> Result<gst::FlowSuccess, gst::FlowError> { fn finish(&self, element: &Self::Type) -> Result<gst::FlowSuccess, gst::FlowError> {
gst_info!(CAT, obj: element, "Finishing"); gst_info!(CAT, obj: element, "Finishing");
self.flush_decoder(element);
self.forward_pending_pictures(element)?; {
let mut state_guard = self.state.lock().unwrap();
self.flush_decoder(element, &mut state_guard);
let _state_guard = self.forward_pending_pictures(element, state_guard)?;
}
self.parent_finish(element) self.parent_finish(element)
} }