mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-02-13 11:27:33 +00:00
Code Issues Projects Releases Wiki Activity

webrtcsink: don't panic on failure to request pad from webrtcbin

Browse source 
webrtcbin will refuse pad requests for all sorts of reasons, and should
be logging an error when doing so, simply post an error message and let
the application deal with it, the reason for the refusal should
hopefully be available in the logs to the user.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1411>
This commit is contained in:
Mathieu Duponchelle 2023-11-24 19:53:38 +01:00 committed by Sebastian Dröge
parent 55d2b9483c
commit 630a1120ba
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
net/webrtc/src/webrtcsink/imp.rs
View file

@ -1142,10 +1142,20 @@ impl Session {
payloader_caps
);
let pad = self
let pad = if let Some(pad) = self
.webrtcbin
.request_pad_simple(&format!("sink_{}", media_idx))
.unwrap();
{
pad
} else {
gst::error!(CAT, obj: element, "Failed to request pad from webrtcbin");
gst::element_error!(
element,
gst::StreamError::Failed,
["Failed to request pad from webrtcbin"]
);
return;
};
let transceiver = pad.property::<gst_webrtc::WebRTCRTPTransceiver>("transceiver");