mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-01-19 07:35:46 +00:00
Code Issues Projects Releases Wiki Activity

s3sink: Dont set call_timeout,call_attempt_timeout is enough with retry.

Browse source 
When call_timeout is triggered, request will fail
irrespective of the retry setting. call_timeout define
max time request can take along with retry.
It can be solved by either setting call_timeout to
retry * call_attempt_timeout or not setting the call_timeout.

As per thread call_attempt and rety setting is enough.
https://github.com/awslabs/aws-sdk-rust/issues/558
This commit is contained in:
rajneeshksoni 2022-09-09 09:49:57 +05:30 committed by Sebastian Dröge
parent 1be30b8ecc
commit 62f76e1e8b
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
net/aws/src/s3utils.rs
View file

@ -99,10 +99,6 @@ pub fn wait_stream(
pub fn timeout_config(request_timeout: Duration) -> timeout::Config {
timeout::Config::new().with_api_timeouts(
timeout::Api::new()
// This timeout acts at the "Request to a service" level. When the SDK makes a request to a
// service, that "request" can contain several HTTP requests. This way, you can retry
// failures that are likely spurious, or refresh credentials.
.with_call_timeout(TriState::Set(request_timeout))
// This timeout acts at the "HTTP request" level and sets a separate timeout for each
// HTTP request made as part of a "service request."
.with_call_attempt_timeout(TriState::Set(request_timeout)),