Fix various new clippy warnings with clippy 1.43

audio/audiofx/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

audio/audiofx/src/audioecho.rs

@@ -6,14 +6,10 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_audio;
-use gst_base;
 use gst_base::subclass::prelude::*;
 
 use std::sync::Mutex;

audio/audiofx/src/audioloudnorm.rs

@@ -18,14 +18,10 @@
 // License along with FFmpeg; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_audio;
-use gst_base;
 
 use std::mem;
 use std::sync::Mutex;

audio/audiofx/tests/audioloudnorm.rs

@@ -14,10 +14,6 @@
 // License along with this library; if not, write to the
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
-use gstrsaudiofx;
-
-use glib;
-
 extern crate gstreamer as gst;
 extern crate gstreamer_app as gst_app;
 extern crate gstreamer_audio as gst_audio;

audio/claxon/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

audio/claxon/src/claxondec.rs

@@ -6,12 +6,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::subclass::prelude::*;
-use gst_audio;
 use gst_audio::prelude::*;
 use gst_audio::subclass::prelude::*;
 

audio/csound/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

audio/csound/examples/effect_example.rs

@@ -15,14 +15,9 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
-use gstcsound;
-
 use std::error::Error;
 
 const AUDIO_SRC: &str = "audiotestsrc";

audio/csound/src/filter.rs

@@ -15,19 +15,15 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{
     gst_debug, gst_element_error, gst_error, gst_error_msg, gst_info, gst_log, gst_loggable_error,
     gst_warning,
 };
-use gst_audio;
-use gst_base;
 use gst_base::subclass::base_transform::GenerateOutputSuccess;
 use gst_base::subclass::prelude::*;
 

audio/csound/src/lib.rs

@@ -17,8 +17,6 @@
 
 #![crate_type = "cdylib"]
 
-use glib;
-use gst;
 use gst::gst_plugin_define;
 
 mod filter;

audio/csound/tests/csound_filter.rs

@@ -14,13 +14,6 @@
 // License along with this library; if not, write to the
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
-use gstcsound;
-
-use glib;
-
-use gst;
-use gst_check;
-
 use glib::prelude::*;
 use gst::prelude::*;
 

audio/lewton/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

audio/lewton/src/lewtondec.rs

@@ -6,12 +6,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::subclass::prelude::*;
-use gst_audio;
 use gst_audio::prelude::*;
 use gst_audio::subclass::prelude::*;
 

audio/transcribe/build.rs

@@ -1,5 +1,3 @@
-use gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

audio/transcribe/src/aws_transcribe_parse.rs

@@ -15,18 +15,15 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 
 use std::default::Default;
 
 use rusoto_core::Region;
-use rusoto_credential;
 use rusoto_credential::{EnvironmentProvider, ProvideAwsCredentials};
 
 use rusoto_signature::signature::SignedRequest;

generic/file/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

generic/sodium/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

generic/sodium/examples/decrypt_example.rs

@@ -32,7 +32,6 @@ use std::path::PathBuf;
 
 use clap::{App, Arg};
 use serde::{Deserialize, Serialize};
-use serde_json;
 
 #[derive(Debug, Serialize, Deserialize)]
 struct Keys {

generic/sodium/examples/encrypt_example.rs

@@ -32,7 +32,6 @@ use std::path::PathBuf;
 
 use clap::{App, Arg};
 use serde::{Deserialize, Serialize};
-use serde_json;
 
 #[derive(Debug, Serialize, Deserialize)]
 struct Keys {

generic/sodium/examples/generate_keys.rs

@@ -24,7 +24,6 @@
 
 use clap::{App, Arg};
 use serde::{Deserialize, Serialize};
-use serde_json;
 use sodiumoxide::crypto::box_;
 use std::fs::File;
 

generic/threadshare/build.rs

@@ -1,7 +1,3 @@
-extern crate cc;
-extern crate gst_plugin_version_helper;
-extern crate pkg_config;
-
 fn main() {
     let gstreamer = pkg_config::probe_library("gstreamer-1.0").unwrap();
     let gstrtp = pkg_config::probe_library("gstreamer-rtp-1.0").unwrap();

generic/threadshare/examples/benchmark.rs

@@ -15,10 +15,7 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
 use std::env;

generic/threadshare/src/appsrc.rs

@@ -20,21 +20,17 @@ use futures::channel::mpsc;
 use futures::lock::Mutex as FutMutex;
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_element_error, gst_error, gst_error_msg, gst_log, gst_trace};
 
 use lazy_static::lazy_static;
 
-use rand;
-
 use std::convert::TryInto;
 use std::sync::Arc;
 use std::sync::Mutex as StdMutex;

generic/threadshare/src/dataqueue.rs

@@ -17,7 +17,6 @@
 
 use futures::future::{self, abortable, AbortHandle};
 
-use gst;
 use gst::gst_debug;
 use gst::prelude::*;
 

generic/threadshare/src/inputselector.rs

@@ -19,13 +19,11 @@ use futures::future::BoxFuture;
 use futures::future::{abortable, AbortHandle};
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_log, gst_trace};

generic/threadshare/src/jitterbuffer/jitterbuffer.rs

@@ -19,13 +19,11 @@ use futures::future::BoxFuture;
 use futures::future::{abortable, AbortHandle, Aborted};
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_error, gst_error_msg, gst_info, gst_log, gst_trace};

generic/threadshare/src/lib.rs

@@ -44,7 +44,6 @@ mod queue;
 use glib::translate::*;
 use glib_sys as glib_ffi;
 
-use gst;
 use gst::gst_plugin_define;
 use gstreamer_sys as gst_ffi;
 

generic/threadshare/src/proxy.rs

@@ -19,13 +19,11 @@ use futures::channel::oneshot;
 use futures::future::BoxFuture;
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_element_error, gst_error, gst_error_msg, gst_log, gst_trace};

generic/threadshare/src/queue.rs

@@ -19,13 +19,11 @@ use futures::channel::oneshot;
 use futures::future::BoxFuture;
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_element_error, gst_error, gst_error_msg, gst_log, gst_trace};

generic/threadshare/src/runtime/executor.rs

@@ -38,7 +38,6 @@ use futures::channel::oneshot;
 use futures::future::BoxFuture;
 use futures::prelude::*;
 
-use gst;
 use gst::{gst_debug, gst_log, gst_trace, gst_warning};
 
 use lazy_static::lazy_static;
@@ -660,13 +659,10 @@ impl Context {
 
 #[cfg(test)]
 mod tests {
-    use futures;
     use futures::channel::mpsc;
     use futures::lock::Mutex;
     use futures::prelude::*;
 
-    use gst;
-
     use std::net::{IpAddr, Ipv4Addr, SocketAddr, UdpSocket};
     use std::sync::Arc;
     use std::time::{Duration, Instant};

generic/threadshare/src/runtime/mod.rs

@@ -58,7 +58,6 @@ pub mod prelude {
 
 pub mod time;
 
-use gst;
 use lazy_static::lazy_static;
 
 lazy_static! {

generic/threadshare/src/runtime/pad.rs

@@ -72,7 +72,6 @@ use futures::future;
 use futures::future::BoxFuture;
 use futures::prelude::*;
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_error, gst_fixme, gst_log, gst_loggable_error};

generic/threadshare/src/socket.rs

@@ -19,7 +19,6 @@
 use futures::future::{abortable, AbortHandle, Aborted, BoxFuture};
 use futures::prelude::*;
 
-use gst;
 use gst::prelude::*;
 use gst::{gst_debug, gst_error, gst_error_msg};
 
@@ -28,7 +27,6 @@ use lazy_static::lazy_static;
 use std::io;
 use std::sync::{Arc, Mutex};
 
-use gio;
 use gio::prelude::*;
 use gio_sys as gio_ffi;
 use gobject_sys as gobject_ffi;

generic/threadshare/src/tcpclientsrc.rs

@@ -20,21 +20,17 @@ use futures::future::BoxFuture;
 use futures::lock::Mutex as FutMutex;
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_element_error, gst_error, gst_error_msg, gst_log, gst_trace};
 
 use lazy_static::lazy_static;
 
-use rand;
-
 use std::io;
 use std::net::{IpAddr, SocketAddr};
 use std::sync::Arc;

generic/threadshare/src/udpsink.rs

@@ -20,13 +20,11 @@ use futures::future::BoxFuture;
 use futures::lock::Mutex;
 use futures::prelude::*;
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::EventView;

generic/threadshare/src/udpsrc.rs

@@ -19,15 +19,11 @@ use futures::future::BoxFuture;
 use futures::lock::Mutex as FutMutex;
 use futures::prelude::*;
 
-use gio;
-
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::{gst_debug, gst_element_error, gst_error, gst_error_msg, gst_log, gst_trace};
@@ -35,8 +31,6 @@ use gst_net::*;
 
 use lazy_static::lazy_static;
 
-use rand;
-
 use std::io;
 use std::net::{IpAddr, Ipv4Addr, Ipv6Addr, SocketAddr};
 use std::sync::Arc;

generic/threadshare/tests/appsrc.rs

@@ -16,14 +16,8 @@
 // Boston, MA 02110-1335, USA.
 
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
-use gst_check;
-
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

generic/threadshare/tests/inputselector.rs

@@ -15,14 +15,8 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
-use gst_check;
-
-use gstthreadshare;
 
 fn init() {
     use std::sync::Once;

generic/threadshare/tests/jitterbuffer.rs

@@ -15,7 +15,6 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use gst;
 use gst::gst_debug;
 use gst::prelude::*;
 
@@ -23,8 +22,6 @@ use lazy_static::lazy_static;
 
 use std::sync::mpsc;
 
-use gstthreadshare;
-
 lazy_static! {
     static ref CAT: gst::DebugCategory = gst::DebugCategory::new(
         "ts-test",

generic/threadshare/tests/pad.rs

@@ -21,11 +21,9 @@ use futures::future::BoxFuture;
 use futures::lock::Mutex as FutMutex;
 use futures::prelude::*;
 
-use glib;
 use glib::GBoxed;
 use glib::{glib_object_impl, glib_object_subclass};
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use gst::EventView;

generic/threadshare/tests/pipeline.rs

@@ -15,7 +15,6 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use gst;
 use gst::prelude::*;
 use gst::{gst_debug, gst_error};
 
@@ -23,8 +22,6 @@ use lazy_static::lazy_static;
 
 use std::sync::mpsc;
 
-use gstthreadshare;
-
 lazy_static! {
     static ref CAT: gst::DebugCategory = gst::DebugCategory::new(
         "ts-test",

generic/threadshare/tests/proxy.rs

@@ -16,16 +16,10 @@
 // Boston, MA 02110-1335, USA.
 
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
-use gst_app;
-
 use std::sync::{Arc, Mutex};
 
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

generic/threadshare/tests/queue.rs

@@ -15,18 +15,11 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
-use gst_app;
-
 use std::sync::{Arc, Mutex};
 
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

generic/threadshare/tests/tcpclientsrc.rs

@@ -16,20 +16,13 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
-
-use gst;
 use gst::prelude::*;
 
-use gst_app;
-
 use std::io::Write;
 use std::sync::{Arc, Mutex};
 use std::{thread, time};
 
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

generic/threadshare/tests/udpsink.rs

@@ -17,14 +17,8 @@
 
 use std::thread;
 
-use glib;
 use glib::prelude::*;
 
-use gst;
-use gst_check;
-
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

generic/threadshare/tests/udpsrc.rs

@@ -15,18 +15,10 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 
-use gio;
-
-use gst;
-use gst_check;
-
 use std::thread;
 
-use gstthreadshare;
-
 fn init() {
     use std::sync::Once;
     static INIT: Once = Once::new();

net/reqwest/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

net/reqwest/src/reqwesthttpsrc.rs

@@ -15,13 +15,10 @@ use reqwest::{Client, Response, StatusCode};
 use tokio::runtime;
 use url::Url;
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_base;
 use gst_base::prelude::*;
 use gst_base::subclass::prelude::*;
 

net/rusoto/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

net/rusoto/src/s3sink.rs

@@ -10,11 +10,9 @@ use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 
-use gst_base;
 use gst_base::subclass::prelude::*;
 
 use futures::prelude::*;

net/rusoto/src/s3src.rs

@@ -18,10 +18,8 @@ use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
 
-use gst;
 use gst::subclass::prelude::*;
 
-use gst_base;
 use gst_base::prelude::*;
 use gst_base::subclass::base_src::CreateSuccess;
 use gst_base::subclass::prelude::*;

text/wrap/build.rs

@@ -1,5 +1,3 @@
-use gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

text/wrap/src/gsttextwrap.rs

@@ -15,11 +15,9 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 
@@ -31,7 +29,6 @@ use std::sync::Mutex;
 use once_cell::sync::Lazy;
 
 use hyphenation::{Load, Standard};
-use textwrap;
 
 static CAT: Lazy<gst::DebugCategory> = Lazy::new(|| {
     gst::DebugCategory::new(

tutorial/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

tutorial/src/identity.rs

@@ -6,11 +6,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 

tutorial/src/lib.rs

@@ -14,10 +14,6 @@ extern crate gstreamer_audio as gst_audio;
 extern crate gstreamer_base as gst_base;
 extern crate gstreamer_video as gst_video;
 
-extern crate byte_slice_cast;
-extern crate num_traits;
-extern crate once_cell;
-
 mod identity;
 mod progressbin;
 mod rgb2gray;

tutorial/src/progressbin.rs

@@ -6,12 +6,10 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::gobject_sys;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 use std::sync::Mutex;

tutorial/src/rgb2gray.rs

@@ -6,15 +6,11 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_base;
 use gst_base::subclass::prelude::*;
-use gst_video;
 
 use std::i32;
 use std::sync::Mutex;

tutorial/src/sinesrc.rs

@@ -6,14 +6,10 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_audio;
-use gst_base;
 use gst_base::prelude::*;
 use gst_base::subclass::prelude::*;
 

utils/fallbackswitch/build.rs

@@ -1,7 +1,3 @@
-extern crate cc;
-extern crate gst_plugin_version_helper;
-extern crate pkg_config;
-
 fn main() {
     gst_plugin_version_helper::get_info();
 

utils/fallbackswitch/src/base/aggregator.rs

@@ -13,7 +13,6 @@ use glib::signal::{connect_raw, SignalHandlerId};
 use glib::translate::*;
 use glib::IsA;
 use glib::Value;
-use gst;
 use std::boxed::Box as Box_;
 use std::mem;
 use std::ptr;

utils/fallbackswitch/src/base/aggregator_pad.rs

@@ -10,8 +10,6 @@ use super::gst_base_sys;
 use super::AggregatorPad;
 use glib::object::IsA;
 use glib::translate::*;
-use gst;
-use gst_sys;
 
 pub trait AggregatorPadExtManual: 'static {
     fn get_segment(&self) -> gst::Segment;

utils/fallbackswitch/src/base/auto/aggregator.rs

@@ -10,9 +10,6 @@ use glib::signal::SignalHandlerId;
 use glib::translate::*;
 use glib::StaticType;
 use glib::Value;
-use glib_sys;
-use gobject_sys;
-use gst;
 use std::boxed::Box as Box_;
 use std::mem::transmute;
 

utils/fallbackswitch/src/base/auto/aggregator_pad.rs

@@ -10,10 +10,6 @@ use glib::signal::SignalHandlerId;
 use glib::translate::*;
 use glib::StaticType;
 use glib::Value;
-use glib_sys;
-use gobject_sys;
-use gst;
-use gst_sys;
 use std::boxed::Box as Box_;
 use std::mem::transmute;
 

utils/fallbackswitch/src/base/subclass/aggregator.rs

@@ -6,16 +6,11 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use libc;
-
 use super::super::gst_base_sys;
-use glib_sys;
-use gst_sys;
 
 use glib::translate::*;
 
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 

utils/fallbackswitch/src/base/subclass/aggregator_pad.rs

@@ -7,11 +7,8 @@
 // except according to those terms.
 
 use super::super::gst_base_sys;
-use glib_sys;
-use gst_sys;
 
 use glib::translate::*;
-use gst;
 
 use glib::subclass::prelude::*;
 use gst::subclass::prelude::*;

utils/fallbackswitch/src/base/utils.rs

@@ -7,7 +7,6 @@
 // except according to those terms.
 
 use glib::translate::mut_override;
-use glib_sys;
 
 #[must_use = "if unused the Mutex will immediately unlock"]
 pub struct MutexGuard<'a>(&'a glib_sys::GMutex);

utils/fallbackswitch/src/fallbackswitch.rs

@@ -17,19 +17,13 @@
 
 #[cfg(not(feature = "v1_18"))]
 use super::base as gst_base;
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_audio;
-#[cfg(feature = "v1_18")]
-use gst_base;
 use gst_base::prelude::*;
 use gst_base::subclass::prelude::*;
-use gst_video;
 
 use once_cell::sync::Lazy;
 

utils/togglerecord/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

utils/togglerecord/src/togglerecord.rs

@@ -15,15 +15,11 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_audio;
-use gst_video;
 
 use parking_lot::{Condvar, Mutex};
 use std::cmp;

video/cdg/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

video/cdg/src/cdgdec.rs

@@ -6,17 +6,12 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use cdg;
-use cdg_renderer;
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::subclass::prelude::*;
 use gst_video::prelude::VideoDecoderExtManual;
 use gst_video::prelude::*;
 use gst_video::subclass::prelude::*;
-use gstreamer_video as gst_video;
 use image::GenericImageView;
 use std::sync::Mutex;
 

video/cdg/src/cdgparse.rs

@@ -6,16 +6,13 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::subclass::prelude::*;
 use gst::SECOND_VAL;
 use gst_base::prelude::*;
 use gst_base::subclass::prelude::*;
 use gstreamer::format::Bytes;
-use gstreamer_base as gst_base;
 use std::convert::TryInto;
 
 use crate::constants::{

video/cdg/src/lib.rs

@@ -12,6 +12,8 @@
 extern crate glib;
 #[macro_use]
 extern crate gstreamer as gst;
+extern crate gstreamer_base as gst_base;
+extern crate gstreamer_video as gst_video;
 #[macro_use]
 extern crate lazy_static;
 

video/cdg/tests/cdgdec.rs

@@ -6,12 +6,11 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use gst_app::prelude::*;
+extern crate gstreamer as gst;
-use gstreamer as gst;
+extern crate gstreamer_app as gst_app;
-use gstreamer_app as gst_app;
-use std::path::PathBuf;
 
-use gstcdg;
+use gst::prelude::*;
+use std::path::PathBuf;
 
 fn init() {
     use std::sync::Once;

video/closedcaption/build.rs

@@ -1,6 +1,3 @@
-extern crate cc;
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info();
 

video/closedcaption/src/cea608tott.rs

@@ -6,11 +6,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 

video/closedcaption/src/mcc_enc.rs

@@ -15,15 +15,12 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::structure;
 use gst::subclass::prelude::*;
-use gst_video;
 
 use chrono::prelude::*;
 use uuid::Uuid;

video/closedcaption/src/mcc_parse.rs

@@ -15,14 +15,12 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_video::{self, ValidVideoTimeCode};
+use gst_video::ValidVideoTimeCode;
 
 use std::cmp;
 use std::convert::TryInto;
@@ -982,8 +980,8 @@ impl MccParse {
             }
             EventView::FlushStop(_) => {
                 let state = self.state.lock().unwrap();
-
+                let state = self.flush(state);
-                let _ = self.flush(state);
+                drop(state);
 
                 pad.event_default(Some(element), event)
             }

video/closedcaption/src/mcc_parser.rs

@@ -17,7 +17,6 @@
 
 use either::Either;
 
-use combine;
 use combine::parser::byte::hex_digit;
 use combine::parser::range::{range, take_while1};
 use combine::parser::repeat::skip_many;

video/closedcaption/src/scc_enc.rs

@@ -16,11 +16,9 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::structure;
 use gst::subclass::prelude::*;

video/closedcaption/src/scc_parse.rs

@@ -16,14 +16,11 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_video;
 
 use std::sync::{Mutex, MutexGuard};
 

video/closedcaption/src/scc_parser.rs

@@ -16,7 +16,6 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use combine;
 use combine::parser::byte::hex_digit;
 use combine::parser::range::{range, take_while1};
 use combine::parser::EasyParser;

video/closedcaption/src/tttocea608.rs

@@ -15,11 +15,9 @@
 // Free Software Foundation, Inc., 51 Franklin Street, Suite 500,
 // Boston, MA 02110-1335, USA.
 
-use glib;
 use glib::prelude::*;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
 

video/dav1d/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

video/dav1d/src/dav1ddec.rs

@@ -6,14 +6,10 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use dav1d;
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::prelude::*;
 use gst::subclass::prelude::*;
-use gst_video;
 use gst_video::prelude::*;
 use gst_video::subclass::prelude::*;
 

video/flavors/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

video/flavors/src/flvdemux.rs

@@ -9,18 +9,13 @@
 use std::cmp;
 use std::sync::Mutex;
 
-use nom;
-
 // FIXME: rustfmt removes the :: but they're required here
 #[rustfmt::skip]
 use ::flavors::parser as flavors;
 
-use crate::gst;
-use crate::gst::prelude::*;
-use crate::gst::subclass::prelude::*;
-use crate::gst_base;
-use glib;
 use glib::subclass;
+use gst::prelude::*;
+use gst::subclass::prelude::*;
 
 use num_rational::Rational32;
 

video/gif/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

video/rav1e/build.rs

@@ -1,5 +1,3 @@
-extern crate gst_plugin_version_helper;
-
 fn main() {
     gst_plugin_version_helper::get_info()
 }

video/rav1e/src/lib.rs

@@ -12,6 +12,7 @@
 extern crate glib;
 #[macro_use]
 extern crate gstreamer as gst;
+extern crate gstreamer_video as gst_video;
 #[macro_use]
 extern crate lazy_static;
 

video/rav1e/src/rav1enc.rs

@@ -7,14 +7,11 @@
 // except according to those terms.
 
 use atomic_refcell::AtomicRefCell;
-use glib;
 use glib::subclass;
 use glib::subclass::prelude::*;
-use gst;
 use gst::subclass::prelude::*;
 use gst_video::prelude::*;
 use gst_video::subclass::prelude::*;
-use gstreamer_video as gst_video;
 use rav1e::color;
 use rav1e::config;
 use rav1e::data;