mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-09-02 09:43:48 +00:00
Code Issues Projects Releases Wiki Activity

rtprecv: Drop state lock before chaining RTCP packets from the RTP chain function

Browse source 
Otherwise the state lock is taken twice and will cause a deadlock.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2381>
This commit is contained in:
Sebastian Dröge 2025-07-16 18:02:21 +03:00
parent 71d723de48
commit 31af6cb46b
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/rtp/src/rtpbin2/rtprecv.rs
View file

@ -1501,7 +1501,10 @@ impl RtpRecv {
RecvRtpBuffer::SsrcCollision(ssrc) => { RecvRtpBuffer::SsrcCollision(ssrc) => {
return self.handle_ssrc_collision(session, [ssrc]) return self.handle_ssrc_collision(session, [ssrc])
} }
RecvRtpBuffer::IsRtcp(buffer) => return Self::rtcp_sink_chain(self, id, buffer), RecvRtpBuffer::IsRtcp(buffer) => {
drop(state);
return Self::rtcp_sink_chain(self, id, buffer);
}
RecvRtpBuffer::Drop => None, RecvRtpBuffer::Drop => None,
RecvRtpBuffer::Forward((buffer, jb)) => Some((buffer, jb)), RecvRtpBuffer::Forward((buffer, jb)) => Some((buffer, jb)),
}; };