mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-26 21:41:03 +00:00
Code Issues Projects Releases Wiki Activity

Element::request_new_pad() is (transfer none) in the return value

Browse source 
Which is effectively unsafe, but nothing we can do about that right now
without leaking all pads.

https://bugzilla.gnome.org/show_bug.cgi?id=791193
This commit is contained in:
Sebastian Dröge 2017-12-04 11:08:16 +02:00
parent a271b18c09
commit 2fb3952aa2
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
gst-plugin/src/element.rs
View file

@ -263,9 +263,23 @@ where
Some(gst::CapsRef::from_ptr(caps)) Some(gst::CapsRef::from_ptr(caps))
}; };
panic_to_error!(&wrap, &element.panicked, None, { // XXX: This is effectively unsafe but the best we can do
// See https://bugzilla.gnome.org/show_bug.cgi?id=791193
let pad = panic_to_error!(&wrap, &element.panicked, None, {
imp.request_new_pad(&wrap, &from_glib_borrow(templ), from_glib_none(name), caps) imp.request_new_pad(&wrap, &from_glib_borrow(templ), from_glib_none(name), caps)
}).to_glib_full() });
// Ensure that the pad is owned by the element now, if a pad was returned
if let Some(ref pad) = pad {
assert_eq!(
pad.get_parent(),
Some(gst::Object::from_glib_borrow(
ptr as *mut gst_ffi::GstObject
))
);
}
pad.to_glib_none().0
} }
unsafe extern "C" fn element_release_pad<T: ElementBase>( unsafe extern "C" fn element_release_pad<T: ElementBase>(