mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2025-02-16 04:45:15 +00:00
Code Issues Projects Releases Wiki Activity

webrtcsink: don't forget to setup encoders for discoveries

Browse source 
The "encoder-setup" signal must also be emitted for the encoders
used in discovery pipelines in order for the default settings to
be applied.

This otherwise meant that for instance the x264 encoder would
use a 60 frames latency, greatly delaying startup.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1327>
This commit is contained in:
Mathieu Duponchelle 2023-08-01 00:28:52 +02:00 committed by Sebastian Dröge
parent 257a0de483
commit 1ccc93df07
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
net/webrtc/src/webrtcsink/imp.rs
View file

@ -2144,6 +2144,7 @@ impl WebRTCSink {
async fn run_discovery_pipeline( async fn run_discovery_pipeline(
element: &super::WebRTCSink, element: &super::WebRTCSink,
stream_name: &str,
codec: &Codec, codec: &Codec,
caps: &gst::Caps, caps: &gst::Caps,
) -> Result<gst::Structure, Error> { ) -> Result<gst::Structure, Error> {
@ -2173,7 +2174,12 @@ impl WebRTCSink {
gst::Element::link_many(elements_slice) gst::Element::link_many(elements_slice)
.with_context(|| format!("Running discovery pipeline for caps {}", caps))?; .with_context(|| format!("Running discovery pipeline for caps {}", caps))?;
let (_, _, pay) = setup_encoding(&pipe.0, &capsfilter, caps, codec, None, true)?; let (enc, _, pay) = setup_encoding(&pipe.0, &capsfilter, caps, codec, None, true)?;
element.emit_by_name::<bool>(
"encoder-setup",
&[&"discovery".to_string(), &stream_name, &enc],
);
let sink = make_element("fakesink", None)?; let sink = make_element("fakesink", None)?;
@ -2260,7 +2266,9 @@ impl WebRTCSink {
let futs = codecs let futs = codecs
.iter() .iter()
.filter(|(_, codec)| codec.is_video() == is_video) .filter(|(_, codec)| codec.is_video() == is_video)
.map(|(_, codec)| WebRTCSink::run_discovery_pipeline(element, codec, &sink_caps)); .map(|(_, codec)| {
WebRTCSink::run_discovery_pipeline(element, &name, codec, &sink_caps)
});
for ret in futures::future::join_all(futs).await { for ret in futures::future::join_all(futs).await {
match ret { match ret {
@ -2719,7 +2727,8 @@ impl ObjectImpl for WebRTCSink {
.build(), .build(),
/** /**
* RsWebRTCSink::encoder-setup: * RsWebRTCSink::encoder-setup:
* @consumer_id: Identifier of the consumer * @consumer_id: Identifier of the consumer, or "discovery"
* when the encoder is used in a discovery pipeline.
* @pad_name: The name of the corresponding input pad * @pad_name: The name of the corresponding input pad
* @encoder: The constructed encoder * @encoder: The constructed encoder
* *