mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-11-26 21:41:03 +00:00
Code Issues Projects Releases Wiki Activity

aws: s3sink: Add a deprecation warning for retry duration properties

Browse source 
Keeping the upload-part-retry-duration & complete-upload-retry-duration
properties changes the semantics in comparison to their usage in
rusotos3sink. Deprecate these two properties and add a warning while
making them noop.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/759>
This commit is contained in:
Sanchayan Maity 2022-06-06 18:57:50 +05:30 committed by Sebastian Dröge
parent 511ee766df
commit 19f69614a2
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/aws/src/s3sink/imp.rs
View file

@ -834,7 +834,7 @@ impl ObjectImpl for S3Sink {
settings.request_timeout = settings.request_timeout =
duration_from_millis(value.get::<i64>().expect("type checked upstream")); duration_from_millis(value.get::<i64>().expect("type checked upstream"));
} }
"retry-duration" | "upload-part-retry-duration" | "complete-upload-retry-duration" => { "retry-duration" => {
/* /*
* To maintain backwards compatibility calculate retry attempts * To maintain backwards compatibility calculate retry attempts
* by dividing the provided duration from request timeout. * by dividing the provided duration from request timeout.
@ -848,6 +848,9 @@ impl ObjectImpl for S3Sink {
}; };
settings.retry_attempts = retry_attempts as u32; settings.retry_attempts = retry_attempts as u32;
} }
"upload-part-retry-duration" | "complete-upload-retry-duration" => {
gst::warning!(CAT, "Use retry-attempts. retry/upload-part/complete-upload-retry duration are deprecated.");
}
_ => unimplemented!(), _ => unimplemented!(),
} }
} }