mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-12-24 02:50:34 +00:00
Code Issues Projects Releases Wiki Activity

ts-appsrc: Fix deadlock during shutdown

Browse source 
The IO Context has to be alive longer than the other parts
of the state. Otherwise a deadlock can happen between shutting down
the IO context (thread join while the state lock is held) and stuff
happening on the IO context (which might take the state lock).
This commit is contained in:
Sebastian Dröge 2018-12-13 17:11:48 +02:00
parent 6bd4931120
commit 0792fe4f1a
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
gst-plugin-threadshare/src/appsrc.rs
View file

@ -418,15 +418,25 @@ impl AppSrc {
fn unprepare(&self, element: &gst::Element) -> Result<(), ()> {
gst_debug!(self.cat, obj: element, "Unpreparing");
let mut state = self.state.lock().unwrap();
// FIXME: The IO Context has to be alive longer than the other parts
// of the state. Otherwise a deadlock can happen between shutting down
// the IO context (thread join while the state lock is held) and stuff
// happening on the IO context (which might take the state lock).
let io_context = {
let mut state = self.state.lock().unwrap();
if let (&Some(ref pending_future_id), &Some(ref io_context)) =
(&state.pending_future_id, &state.io_context)
{
io_context.release_pending_future_id(*pending_future_id);
}
if let (&Some(ref pending_future_id), &Some(ref io_context)) =
(&state.pending_future_id, &state.io_context)
{
io_context.release_pending_future_id(*pending_future_id);
}
*state = State::default();
let io_context = state.io_context.take();
*state = State::default();
io_context
};
drop(io_context);
gst_debug!(self.cat, obj: element, "Unprepared");