Merge pull request 'adding the ability to change the default podManagementPolicy for StatefulSets' (#823) from bodaciousbiscuits/garage:main into main

Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/823
Reviewed-by: maximilien <me@mricher.fr>

doc/book/reference-manual/configuration.md

@@ -414,7 +414,7 @@ month, with a random delay to avoid all nodes running at the same time.  When
 it scrubs the data directory, Garage will read all of the data files stored on
 disk to check their integrity, and will rebuild any data files that it finds
 corrupted, using the remaining valid copies stored on other nodes.
-See [this page](@/documentation/operations/durability-repair.md#scrub) for details.
+See [this page](@/documentation/operations/durability-repairs.md#scrub) for details.
 
 Set the `disable_scrub` configuration value to `true` if you don't need Garage
 to scrub the data directory, for instance if you are already scrubbing at the

doc/book/working-documents/migration-1.md

@@ -19,15 +19,15 @@ The following are **breaking changes** in Garage v1.0 that require your attentio
 - The Sled metadata db engine has been **removed**. If your cluster was still
   using Sled, you will need to **use a Garage v0.9.x binary** to convert the
   database using the `garage convert-db` subcommand. See
-  [here](@/documentation/reference-manual/configuration/#db_engine) for the
+  [here](@/documentation/reference-manual/configuration.md#db_engine) for the
   details of the procedure.
 
 The following syntax changes have been made to the configuration file:
 
 - The `replication_mode` parameter has been split into two parameters:
-  [`replication_factor`](@/documentation/reference-manual/configuration/#replication_factor)
+  [`replication_factor`](@/documentation/reference-manual/configuration.md#replication_factor)
   and
-  [`consistency_mode`](@/documentation/reference-manual/configuration/#consistency_mode).
+  [`consistency_mode`](@/documentation/reference-manual/configuration.md#consistency_mode).
   The old syntax using `replication_mode` is still supported for legacy
   reasons and can still be used.
 

flake.nix

@@ -76,6 +76,7 @@
             # import the full shell using `nix develop .#full`
             full = shellWithPackages (with pkgs; [
               rustfmt
+              rust-analyzer
               clang
               mold
               # ---- extra packages for dev tasks ----

script/helm/garage/templates/workload.yaml

@@ -11,6 +11,7 @@ spec:
   {{- if eq .Values.deployment.kind "StatefulSet" }}
   replicas: {{ .Values.deployment.replicaCount }}
   serviceName: {{ include "garage.fullname" . }}
+  podManagementPolicy: {{ .Values.deployment.podManagementPolicy }}
   {{- end }}
   template:
     metadata:

script/helm/garage/values.yaml

@@ -96,6 +96,8 @@ deployment:
   kind: StatefulSet
   # Number of StatefulSet replicas/garage nodes to start
   replicaCount: 3
+  # If using statefulset, allow Parallel or OrderedReady (default)
+  podManagementPolicy: OrderedReady
 
 image:
   repository: dxflrs/amd64_garage

shell.nix

@@ -11,6 +11,7 @@ in
 {
   # --- Dev shell inherited from flake.nix ---
   devShell = devShells.default;
+  devShellFull = devShells.full;
 
   # --- Continuous integration shell ---
   # The shell used for all CI jobs (along with devShell)

src/garage/cli/structs.rs

@@ -48,7 +48,7 @@ pub enum Command {
 	#[structopt(name = "worker", version = garage_version())]
 	Worker(WorkerOperation),
 
-	/// Low-level debug operations on data blocks
+	/// Low-level node-local debug operations on data blocks
 	#[structopt(name = "block", version = garage_version())]
 	Block(BlockOperation),