Commit graph

49 commits

Author SHA1 Message Date
Alex Auvolat
1ee8f596ee
Testing for UploadPartCopies and bugfixes in AWS signatures 2022-01-13 14:03:30 +01:00
Quentin
b4592a00fe Implement ListMultipartUploads (#171)
Implement ListMultipartUploads, also refactor ListObjects and ListObjectsV2.

It took me some times as I wanted to propose the following things:
  - Using an iterator instead of the loop+goto pattern. I find it easier to read and it should enable some optimizations. For example, when consuming keys of a common prefix, we do many [redundant checks](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/main/src/api/s3_list.rs#L125-L156) while the only thing to do is to [check if the following key is still part of the common prefix](https://git.deuxfleurs.fr/Deuxfleurs/garage/src/branch/feature/s3-multipart-compat/src/api/s3_list.rs#L476).
  - Try to name things (see ExtractionResult and RangeBegin enums) and to separate concerns (see ListQuery and Accumulator)
  - An IO closure to make unit tests possibles.
  - Unit tests, to track regressions and document how to interact with the code
  - Integration tests with `s3api`. In the future, I would like to move them in Rust with the aws rust SDK.

Merging of the logic of ListMultipartUploads and ListObjects was not a goal but a consequence of the previous modifications.

Some points that we might want to discuss:
  - ListObjectsV1, when using pagination and delimiters, has a weird behavior (it lists multiple times the same prefix) with `aws s3api` due to the fact that it can not use our optimization to skip the whole prefix. It is independant from my refactor and can be tested with the commented `s3api` tests in `test-smoke.sh`. It probably has the same weird behavior on the official AWS S3 implementation.
  - Considering ListMultipartUploads, I had to "abuse" upload id marker to support prefix skipping. I send an `upload-id-marker` with the hardcoded value `include` to emulate your "including" token.
  - Some ways to test ListMultipartUploads with existing software (my tests are limited to s3api for now).

Co-authored-by: Quentin Dufour <quentin@deuxfleurs.fr>
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/171
Co-authored-by: Quentin <quentin@dufour.io>
Co-committed-by: Quentin <quentin@dufour.io>
2022-01-12 19:04:55 +01:00
trinity-1686a
1eb972b1ac Add compression using zstd (#173)
fix #27

Co-authored-by: Trinity Pointard <trinity.pointard@gmail.com>
Reviewed-on: https://git.deuxfleurs.fr/Deuxfleurs/garage/pulls/173
Co-authored-by: trinity-1686a <trinity.pointard@gmail.com>
Co-committed-by: trinity-1686a <trinity.pointard@gmail.com>
2021-12-15 11:26:43 +01:00
Quentin Dufour
8811bb08e6
In ListBuckets, hide entry if no perms 2021-11-22 12:10:28 +01:00
Quentin Dufour
85b2e4ca29
Start socat only once
Fixes #124
2021-11-17 10:59:32 +01:00
Alex Auvolat
c94406f428
Improve how node roles are assigned in Garage
- change the terminology: the network configuration becomes the role
  table, the configuration of a nodes becomes a node's role
- the modification of the role table takes place in two steps: first,
  changes are staged in a CRDT data structure. Then, once the user is
  happy with the changes, they can commit them all at once (or revert
  them).
- update documentation
- fix tests
- implement smarter partition assignation algorithm

This patch breaks the format of the network configuration: when
migrating, the cluster will be in a state where no roles are assigned.
All roles must be re-assigned and commited at once. This migration
should not pose an issue.
2021-11-16 16:05:53 +01:00
Alex Auvolat
de4276202a
Improve CLI, adapt tests, update documentation 2021-10-25 14:21:48 +02:00
Quentin Dufour
dc017a0cab
Build Garage with Nix 2021-10-19 16:56:07 +02:00
Alex Auvolat
ddb2b29bfd
Rename datacenters into zones (doc not yet updated) 2021-05-28 14:07:36 +02:00
Alex Auvolat
b490ebc7f6
Many improvements on ring/replication and its configuration:
- Explicit "replication_mode" configuration parameters that takes
  either "none", "2" or "3" as values, instead of letting user configure
  replication factor themselves. These are presets whose corresponding
  replication/quorum values can be found in replication/mode.rs

- Explicit support for single-node and two-node deployments
  (number of nodes must be at least "replication_mode", with "none"
  we can have only one node)

- Ring is now stored much more compactly with 256*8 + n*32 bytes,
  instead of 256*32 bytes

- Support for gateway-only nodes that do not store data
  (these nodes still need a metadata_directory to store the list
  of bucket and keys since those are stored on all nodes; it also
  technically needs a data_directory to start but it will stay
  empty unless we have bugs)
2021-05-28 14:07:36 +02:00
Quentin Dufour
c8aa1eb481
Add preliminary support for Duck 2021-05-15 10:24:20 +02:00
Trinity Pointard
88925ebe22
add clippy to the CI 2021-05-03 22:11:37 +02:00
Quentin Dufour
631c36b3ff S3 API: support ListBuckets 2021-05-03 21:55:30 +02:00
Quentin Dufour
ef4d6e782a
Add minio & rclone to our functional tests
It is now possible to configure which clients
you do not want to test with the env variable SKIP_XXX=1,
XXX being the client name. eg. SKIP_S3CMD=1 ./script/test-smoke.sh
2021-05-02 14:59:58 +02:00
Quentin Dufour
e01f74e763
Introduce test case that demonstrates #59 (the & problem) 2021-04-27 23:09:26 +02:00
Alex Auvolat
640e3921d8
Use pre-prepared Docker image in CI to speed things up 2021-04-27 16:37:11 +02:00
Alex Auvolat
5ab33fddac Refactor CLI and prettify CLI outpu 2021-03-12 18:12:31 +01:00
Alex Auvolat
6a3dcf3974 Rename n_tokens into capacity 2021-03-10 14:52:03 +01:00
Alex Auvolat
5e33c3cfc9 Use smaller capacities for nodes 2021-03-05 16:58:34 +01:00
Alex Auvolat
d7e005251d Not fully tested: new multi-dc MagLev 2021-03-05 16:22:29 +01:00
Alex Auvolat
49c25a1509 Simulate stuff moving around 2021-02-25 10:53:33 +01:00
Alex Auvolat
1abbca37c4 Add adapted version of maglev for multi-dc 2021-02-21 19:14:28 +01:00
Alex Auvolat
24f924afdb Maglev simulation 2021-02-21 18:32:13 +01:00
Alex Auvolat
e59322041a Evaluate hash functions 2021-02-21 15:11:15 +01:00
Alex Auvolat
217b0dfd68 Add script to simulate different kinds of rings 2021-02-21 14:30:26 +01:00
Alex Auvolat
3b023c0c3b try to fix smoke test
dev cluster: don't ipv6 (fixes smoke test in container?)
2021-02-17 22:13:11 +01:00
Alex Auvolat
36814be447 Fix S3 ListObjects result and replace println!s by debug!s 2021-01-16 16:05:54 +01:00
Quentin Dufour
086e5be290 Update testing script 2020-12-17 21:04:59 +01:00
Quentin
1119d466e7 Fix S3 command 2020-12-10 20:19:22 +01:00
Quentin
e8c12072ce Merge branch 'master' into feature/website 2020-12-10 20:12:56 +01:00
Quentin
e13fd09543 Reduce garage.1.rnd size to store it inline 2020-12-06 13:33:08 +01:00
Quentin
a92868504f Indentation & comments 2020-12-06 10:23:14 +01:00
Quentin
d2d1fc676d Test awscli/s3cmd interactions 2020-12-06 10:19:01 +01:00
Quentin
a12930075d Test garage list & delete commands 2020-12-06 10:04:17 +01:00
Quentin
28055b708f Improve README, add more tests 2020-12-06 09:13:47 +01:00
Quentin
132c54b807 wip smoke test 2020-12-05 19:26:10 +01:00
Quentin
8df0b322ab Fix merge error 2020-11-29 17:40:36 +01:00
Quentin
a512db342e Merge branch 'master' into feature/website 2020-11-29 17:40:03 +01:00
Alex Auvolat
2f11191f60 Use ipv6 localhost for dev cluster and different port numbers 2020-11-29 17:31:58 +01:00
Quentin
54c3a023f0 Use aws cli version 2 2020-11-29 17:27:49 +01:00
Quentin
15f409d404 Merge branch 'master' into feature/website 2020-11-29 17:19:55 +01:00
Quentin
cee6c3a821 A fix for s3cmd 2020-11-29 17:15:49 +01:00
Quentin
13d1b66ba4 Rollback logging on dev-cluster 2020-11-29 17:07:29 +01:00
Quentin
3f18aa6f1d Add a smoke test script 2020-11-29 17:03:19 +01:00
Quentin
07e87595f8 S3 does not support accentuated buckets + add a script to clean tmp 2020-11-29 17:03:19 +01:00
Quentin
92ab3eedfc Use awscli instead of s3cmd 2020-11-21 15:44:09 +01:00
Quentin
2f6eca4ef3 Merge remote-tracking branch 'origin/master' into feature/website 2020-11-21 10:52:27 +01:00
Alex Auvolat
98e20a5898 Fix dev-env.sh for source; print which garage in dev-cluster.sh 2020-11-20 23:50:23 +01:00
Quentin
993f9d73b1 Quicker dev with more scripts 2020-11-20 20:50:43 +01:00