forgejo/templates
Gergely Nagy d4fc0d2c5a
[GITEA] Allow changing the email address before activation
During registration, one may be required to give their email address, to
be verified and activated later. However, if one makes a mistake, a
typo, they may end up with an account that cannot be activated due to
having a wrong email address.

They can still log in, but not change the email address, thus, no way to
activate it without help from an administrator.

To remedy this issue, lets allow changing the email address for logged
in, but not activated users.

This fixes gitea#17785.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit aaaece28e4)
(cherry picked from commit 639dafabec)
(cherry picked from commit d699c12ceb)

[GITEA] Allow changing the email address before activation (squash) cache is always active

This needs to be revisited because the MailResendLimit is not enforced
and turns out to not be tested.

See e7cb8da2a8 * Always enable caches (#28527)

(cherry picked from commit 43ded8ee30)

Rate limit pre-activation email change separately

Changing the email address before any email address is activated should
be subject to a different rate limit than the normal activation email
resending. If there's only one rate limit for both, then if a newly
signed up quickly discovers they gave a wrong email address, they'd have
to wait three minutes to change it.

With the two separate limits, they don't - but they'll have to wait
three minutes before they can change the email address again.

The downside of this setup is that a malicious actor can alternate
between resending and changing the email address (to something like
`user+$idx@domain`, delivered to the same inbox) to effectively halving
the rate limit. I do not think there's a better solution, and this feels
like such a small attack surface that I'd deem it acceptable.

The way the code works after this change is that `ActivatePost` will now
check the `MailChangeLimit_user` key rather than `MailResendLimit_user`,
and if we're within the limit, it will set `MailChangedJustNow_user`. The
`Activate` method - which sends the activation email, whether it is a
normal resend, or one following an email change - will check
`MailChangedJustNow_user`, and if it is set, it will check the rate
limit against `MailChangedLimit_user`, otherwise against
`MailResendLimit_user`, and then will delete the
`MailChangedJustNow_user` key from the cache.

Fixes #2040.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
(cherry picked from commit e35d2af2e5)
(cherry picked from commit 03989418a7)
(cherry picked from commit f50e0dfe5e)
(cherry picked from commit cad9184a36)
(cherry picked from commit e2da5d7fe1)
(cherry picked from commit 3a80534d4d)
2024-02-05 16:09:41 +01:00
..
admin [GITEA] add option for banning dots in usernames 2024-02-05 16:05:50 +01:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base [GITEA] Improve HTML title on repositories 2024-02-05 16:05:50 +01:00
code Fix 500 error of searching commits (#28576) 2023-12-21 23:09:14 +00:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
explore Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
mail [GITEA] notifies admins on new user registration 2024-02-05 16:09:28 +01:00
org Fix button size in "attached header right" (#28770) 2024-01-12 14:43:40 +00:00
package [GITEA] fix indentation in Maven package install instructions 2024-02-05 16:09:40 +01:00
projects Use full width for project boards (#28225) 2023-11-27 17:43:52 +00:00
repo [GITEA] Allow user to select email for file operations in Web UI 2024-02-05 16:09:41 +01:00
shared Introduce htmx and use it to avoid full page load on Subscribe and Follow (#28908) 2024-01-30 15:45:54 +01:00
status Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
swagger [GITEA] Make HTTPS schema default for Swagger 2024-02-05 16:09:41 +01:00
user [GITEA] Allow changing the email address before activation 2024-02-05 16:09:41 +01:00
webhook Extract common code to new template (#26933) 2023-09-06 10:11:06 +00:00
home.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
install.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
post-install.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00