mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-05-20 09:18:34 +00:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
85 lines
3.6 KiB
Handlebars
85 lines
3.6 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content admin user">
|
|
{{template "admin/navbar" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "admin.repos.unadopted"}}
|
|
<div class="ui right">
|
|
<a class="ui primary tiny button" href="{{AppSubUrl}}/admin/repos">{{.locale.Tr "admin.repos.repo_manage_panel"}}</a>
|
|
</div>
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<form class="ui form ignore-dirty">
|
|
<div class="ui fluid action input">
|
|
<input name="search" value="true" type="hidden">
|
|
<input name="q" value="{{.Keyword}}" placeholder="{{.locale.Tr "repo.adopt_search"}}" autofocus>
|
|
<button class="ui primary button">{{.locale.Tr "explore.search"}}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
{{if .search}}
|
|
<div class="ui attached segment settings">
|
|
{{if .Dirs}}
|
|
<div class="ui middle aligned divided list">
|
|
{{range $dirI, $dir := .Dirs}}
|
|
<div class="item">
|
|
<div class="content">
|
|
<span class="icon">{{svg "octicon-file-directory-fill"}}</span>
|
|
<span class="name">{{$dir}}</span>
|
|
<div class="right floated content">
|
|
<button class="ui button submit tiny green adopt show-modal" data-modal="#adopt-unadopted-modal-{{$dirI}}"><span class="icon">{{svg "octicon-plus"}}</span><span class="label">{{$.locale.Tr "repo.adopt_preexisting_label"}}</span></button>
|
|
<div class="ui basic modal" id="adopt-unadopted-modal-{{$dirI}}">
|
|
{{svg "octicon-x" 16 "close inside"}}
|
|
<div class="header">
|
|
<span class="label">{{$.locale.Tr "repo.adopt_preexisting"}}</span>
|
|
</div>
|
|
<div class="content">
|
|
<p>{{$.locale.Tr "repo.adopt_preexisting_content" $dir}}</p>
|
|
</div>
|
|
<form class="ui form" method="POST" action="{{AppSubUrl}}/admin/repos/unadopted">
|
|
{{$.CsrfTokenHtml}}
|
|
<input type="hidden" name="id" value="{{$dir}}">
|
|
<input type="hidden" name="action" value="adopt">
|
|
<input type="hidden" name="q" value="{{$.Keyword}}">
|
|
<input type="hidden" name="page" value="{{$.CurrentPage}}">
|
|
{{template "base/delete_modal_actions" .}}
|
|
</form>
|
|
</div>
|
|
<button class="ui button submit tiny red delete show-modal" data-modal="#delete-unadopted-modal-{{$dirI}}"><span class="icon">{{svg "octicon-x"}}</span><span class="label">{{$.locale.Tr "repo.delete_preexisting_label"}}</span></button>
|
|
<div class="ui basic modal" id="delete-unadopted-modal-{{$dirI}}">
|
|
{{svg "octicon-x" 16 "close inside"}}
|
|
<div class="header">
|
|
<span class="label">{{$.locale.Tr "repo.delete_preexisting"}}</span>
|
|
</div>
|
|
<div class="content">
|
|
<p>{{$.locale.Tr "repo.delete_preexisting_content" $dir}}</p>
|
|
</div>
|
|
<form class="ui form" method="POST" action="{{AppSubUrl}}/admin/repos/unadopted">
|
|
{{$.CsrfTokenHtml}}
|
|
<input type="hidden" name="id" value="{{$dir}}">
|
|
<input type="hidden" name="action" value="delete">
|
|
<input type="hidden" name="q" value="{{$.Keyword}}">
|
|
<input type="hidden" name="page" value="{{$.CurrentPage}}">
|
|
{{template "base/delete_modal_actions" .}}
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
{{template "base/paginate" .}}
|
|
{{else}}
|
|
<div class="item">
|
|
{{.locale.Tr "admin.repos.unadopted.no_more"}}
|
|
</div>
|
|
{{template "base/paginate" .}}
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
|
|
{{template "base/footer" .}}
|