forgejo/templates/admin
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
applications Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
auth Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
base Optimize html templates (#22080) 2022-12-09 21:34:51 +08:00
emails Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
org Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
packages Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
repo Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
runners Implement actions (#21937) 2023-01-31 09:45:19 +08:00
user Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
config.tmpl Support reflogs (#22451) 2023-03-13 15:51:07 +08:00
cron.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
dashboard.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
hook_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
hooks.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
monitor.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
navbar.tmpl Implement actions (#21937) 2023-01-31 09:45:19 +08:00
notice.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
process-row.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
process.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
queue.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
stacktrace-row.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
stacktrace.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00