mirror of
https://github.com/bookwyrm-social/bookwyrm.git
synced 2024-06-26 00:40:41 +00:00
8d593e4498
This is in response to #1870 Users should not see links to posts they are not allowed to see, in their feed. The main question is how to stop that happening. This commit hides all replies to posts if the original post was "followers only" and the user is not a follower of the original poster. The privacy of the reply is not considered relevant (except "direct"). I believe this is the cleanest way to deal with the problem, as it avoids orphaned replies and confusing 404s, and a reply without access to the context of the original post is not particularly useful to anyone. This also feels like it respects the wishes of the original poster more accurately, as it does not draw attention from non-followers to the original followers-only post. A less draconian approach might be to remove the link to the original status in the feed interface, however that simply leads to confusion of another kind since it will make the interface inconsistent. This commit does not change any ActivityPub behaviour - it only affects the Bookwyrm user feeds. This means orphaned posts may be sent to external apps like Mastodon. |
||
|---|---|---|
| .. | ||
| activitypub | ||
| connectors | ||
| forms | ||
| importers | ||
| management/commands | ||
| middleware | ||
| migrations | ||
| models | ||
| static | ||
| telemetry | ||
| templates | ||
| templatetags | ||
| tests | ||
| utils | ||
| views | ||
| __init__.py | ||
| activitystreams.py | ||
| admin.py | ||
| apps.py | ||
| book_search.py | ||
| context_processors.py | ||
| emailing.py | ||
| imagegenerators.py | ||
| lists_stream.py | ||
| preview_images.py | ||
| redis_store.py | ||
| settings.py | ||
| signatures.py | ||
| status.py | ||
| storage_backends.py | ||
| suggested_users.py | ||
| tasks.py | ||
| thumbnail_generation.py | ||
| urls.py | ||
| wsgi.py | ||