Commit graph

7485 commits

Author SHA1 Message Date
Hugh Rundle
1ee2ff4811 normalise isbn on local book search
- uppercase ISBN before checking it's a number to account for trailing 'x'
- check maybe_isbn for search_identifiers search. Without this we are only searching external connectors, not locally!
2022-08-30 20:00:09 +10:00
Hugh Rundle
68d91086ed add wonky ISBN test 2022-08-30 19:57:25 +10:00
Hugh Rundle
18d3d2f85d linting 2022-08-28 17:30:46 +10:00
Hugh Rundle
f219851f3a strip leading and following spaces from ISBN 2022-08-28 17:28:00 +10:00
Hugh Rundle
da5fd32196 normalise isbn searching
ISBNs are always numeric except for when the check digit in ISBN-10s is a ten, indicated with a capital X.
These changes ensure that ISBNs are always upper-case so that a lower-case 'x' is not used when searching.

Additionally some ancient ISBNs have been printed without a leading zero (i.e. they only have 9 characters on the physical book). This change prepends a zero if something looks like an ISBN but only has 9 chars.
2022-08-28 11:05:40 +10:00
Mouse Reeve
c902301d82
Merge pull request #2281 from hughrun/resetdb
fix resetdb
2022-08-27 09:14:21 -07:00
Hugh Rundle
bc297d663d fix resetdb
Instead of just whining I thought maybe I should fix the problem.

This replaces a manual reset of the database with deletion of the bookwyrm volumes using docker.

fixes #2276
2022-08-27 19:53:57 +10:00
Mouse Reeve
58c3a4c2bc
Merge pull request #2277 from hughrun/permissions
hide replies to posts user cannot see
2022-08-23 19:48:36 -07:00
Hugh Rundle
cc97c52d12 make get_audience logic clearer
Retains 'direct' messages at the top of the logic tree to make it easier to understand.
In practice because direct messages are excluded from feeds anyway, this doesn't seem to make much difference, but it's easier to read.
2022-08-21 09:33:43 +10:00
Hugh Rundle
8d593e4498 hide replies to posts user cannot see
This is in response to #1870

Users should not see links to posts they are not allowed to see, in their feed. The main question is how to stop that happening.
This commit hides all replies to posts if the original post was "followers only" and the user is not a follower of the original poster. The privacy of the reply is not considered relevant (except "direct").

I believe this is the cleanest way to deal with the problem, as it avoids orphaned replies and confusing 404s, and a reply without access to the context of the original post is not particularly useful to anyone. This also feels like it respects the wishes of the original poster more accurately, as it does not draw attention from non-followers to the original followers-only post.

A less draconian approach might be to remove the link to the original status in the feed interface, however that simply leads to confusion of another kind since it will make the interface inconsistent.

This commit does not change any ActivityPub behaviour - it only affects the Bookwyrm user feeds. This means orphaned posts may be sent to external apps like Mastodon.
2022-08-14 14:17:10 +10:00
Mouse Reeve
be1141dddc
Merge pull request #2275 from hughrun/spaceless
strip spaces from user search
2022-08-13 21:15:30 -07:00
Mouse Reeve
987dbe15b3
Merge pull request #2271 from bookwyrm-social/dependabot/pip/django-3.2.15
Bump django from 3.2.14 to 3.2.15
2022-08-13 07:26:44 -07:00
Hugh Rundle
22495e40bd strip spaces from user search
Strips leading and trailing spaces from user search to prevent errors when doing webfinger lookup.
Prior to this, webfinger user queries included everything after the second '@' as part of the hostname. This resulted in failed webfinger requests when there was one or more trailing spaces.
Fixes #2205
2022-08-13 15:40:53 +10:00
dependabot[bot]
c591371b4e
Bump django from 3.2.14 to 3.2.15
Bumps [django](https://github.com/django/django) from 3.2.14 to 3.2.15.
- [Release notes](https://github.com/django/django/releases)
- [Commits](https://github.com/django/django/compare/3.2.14...3.2.15)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-08-11 16:08:55 +00:00
Mouse Reeve
d58282bc37
Merge pull request #2263 from bookwyrm-social/safer-book-description
Safer display of book descriptions
2022-08-09 10:21:11 -07:00
Mouse Reeve
0cf9e1033b Safer display of book descriptions 2022-08-07 13:26:05 -07:00
Mouse Reeve
cbc23dba3b
Merge pull request #2262 from bookwyrm-social/compilescss-command
Removes compilescss command
2022-08-07 11:41:57 -07:00
Mouse Reeve
a5c7ca1cfd Removes compilescss command
This does not work and doesn't reflect how the stylesheets are compiled
any longer.
2022-08-07 11:27:52 -07:00
Mouse Reeve
f566b43e5f
Merge pull request #2261 from bookwyrm-social/duplicate-version-warning
Removes duplicate version warning
2022-08-05 19:13:19 -07:00
Mouse Reeve
1581491471 Removes duplicate version warning 2022-08-05 17:03:56 -07:00
Mouse Reeve
c8fc907705 Update version 2022-08-05 16:54:55 -07:00
Mouse Reeve
9d7ece47ef
Merge pull request #2254 from bookwyrm-social/fixes-search-pagination
Fixes search pagination
2022-08-05 12:32:47 -07:00
Mouse Reeve
9fad5b5623 Fixes isbn view 2022-08-05 11:44:10 -07:00
Mouse Reeve
bdf563748c
Merge pull request #2255 from joachimesque/front/mobile-header
Add notifications count on mobile header
2022-08-05 11:28:42 -07:00
Mouse Reeve
1518dbba86
Merge pull request #2259 from bookwyrm-social/links
Improves rel attrs on links that open on new tabs
2022-08-05 11:28:04 -07:00
Mouse Reeve
7c7df99cef Fixes template syntax error 2022-08-05 11:14:14 -07:00
Mouse Reeve
20572688ba Removes test exception 2022-08-05 11:04:32 -07:00
Mouse Reeve
1ba69acc49 Adds unit tests that checks if rel field is set on links 2022-08-05 11:01:02 -07:00
Mouse Reeve
4dd7f88e0a Updates all links that open in new tabs 2022-08-05 10:20:43 -07:00
Mouse Reeve
9407695328 Updates footer links
Adds a missing rel="nofollow noopener noreferrer" attribute for the
Patreon link, and makes the github link open in a new tab (and updates
the url, which was out of date)
2022-08-05 10:06:12 -07:00
Mouse Reeve
e5611c7c03
Merge pull request #2257 from bookwyrm-social/group-perms
Fixes perms checks for groups
2022-08-05 09:24:22 -07:00
Mouse Reeve
9f22aeacea
Merge pull request #2256 from bookwyrm-social/locales
Locales update
2022-08-05 09:24:08 -07:00
Mouse Reeve
2894aa37a2 Fixes perms checks for groups 2022-08-05 09:12:48 -07:00
Mouse Reeve
44848c6621 Locales update 2022-08-05 09:04:26 -07:00
Mouse Reeve
b4cfda0587 Updates tests 2022-08-05 08:56:24 -07:00
Joachim
610d8fdf5b Add notifications count on mobile header 2022-08-05 11:15:11 +02:00
Mouse Reeve
ed71b791c9 Python formatting 2022-08-04 12:19:26 -07:00
Mouse Reeve
77d1d70207 Much shorter search timeout 2022-08-04 12:16:12 -07:00
Mouse Reeve
48df5076e7 Use elided page range and paginate user and list results 2022-08-04 12:11:39 -07:00
Mouse Reeve
06d1936ac9 Fixes pagination of local search results 2022-08-04 12:04:13 -07:00
Mouse Reeve
0ee7054640
Merge pull request #2253 from bookwyrm-social/otel-fix
Updates and fixes opentelemetry install
2022-08-04 11:25:39 -07:00
Mouse Reeve
073d8b1d67 Updates and fixes opentelemetry install 2022-08-04 11:05:18 -07:00
Mouse Reeve
3270d0a7d4
Merge pull request #2247 from bookwyrm-social/followers-following-views
Merges follower/following views
2022-08-02 11:59:06 -07:00
Mouse Reeve
72281bc459
Merge pull request #2251 from bookwyrm-social/polish-locale
Adds Polish locale
2022-08-02 11:58:42 -07:00
Mouse Reeve
0bc3c3b5f6 Adds locale migration 2022-08-02 11:09:58 -07:00
Mouse Reeve
f9b772e234 Adds polish locale 2022-08-02 10:59:40 -07:00
Mouse Reeve
6d258d5445 Fixes test mocks 2022-07-30 10:07:13 -07:00
Mouse Reeve
d7bf348c77
Merge pull request #2249 from bookwyrm-social/crsf-exempt
Removes improperly placed csrf_exempt decorator
2022-07-29 13:49:29 -07:00
Mouse Reeve
8e2a8ec6e0 Removes improperly places csrf_exempt decorator 2022-07-29 13:40:40 -07:00
Mouse Reeve
96f1521239
Merge pull request #2248 from bookwyrm-social/list-suggestions
Move list suggestions into helper function
2022-07-29 13:27:04 -07:00