mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-11-25 11:01:12 +00:00
Code Issues Projects Releases Wiki Activity

[assets] Replace Array.from(document.getElementsByClassName(…)) by querySelectorAll(…).

Browse source
This commit is contained in:
Fabien Basmaison 2021-04-06 09:11:27 +02:00
parent 6b0a3ce4b1
commit f6c3e581b9
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
bookwyrm/static/js/bookwyrm.js
View file

@ -7,11 +7,11 @@ window.onload = function() {
.forEach(t => t.onclick = toggleAction); .forEach(t => t.onclick = toggleAction);
// javascript interactions (boost/fav) // javascript interactions (boost/fav)
Array.from(document.getElementsByClassName('interaction')) document.querySelectorAll('.interaction')
.forEach(t => t.onsubmit = interact); .forEach(t => t.onsubmit = interact);
// handle aria settings on menus // handle aria settings on menus
Array.from(document.getElementsByClassName('pulldown-menu')) document.querySelectorAll('.pulldown-menu')
.forEach(t => t.onclick = toggleMenu); .forEach(t => t.onclick = toggleMenu);
// hidden submit button in a form // hidden submit button in a form
@ -26,7 +26,7 @@ window.onload = function() {
document.querySelectorAll('[data-back]') document.querySelectorAll('[data-back]')
.forEach(t => t.onclick = back); .forEach(t => t.onclick = back);
Array.from(document.getElementsByClassName('tab-group')) document.querySelectorAll('.tab-group')
.forEach(t => new TabGroup(t)); .forEach(t => new TabGroup(t));
}; };
@ -103,7 +103,9 @@ function interact(e) {
e.preventDefault(); e.preventDefault();
ajaxPost(e.target); ajaxPost(e.target);
var identifier = e.target.getAttribute('data-id'); var identifier = e.target.getAttribute('data-id');
Array.from(document.getElementsByClassName(identifier)) // @todo This should be `querySelector`, unless there are duplicated IDs,
// which is a problem in itself.
document.querySelectorAll(`#${identifier}`)
.forEach(t => addRemoveClass(t, 'hidden', t.className.indexOf('hidden') == -1)); .forEach(t => addRemoveClass(t, 'hidden', t.className.indexOf('hidden') == -1));
} }

2
bookwyrm/static/js/localstorage.js
View file

@ -24,5 +24,5 @@ document.querySelectorAll('[data-hide]')
.forEach(t => setDisplay(t)); .forEach(t => setDisplay(t));
// update localstorage // update localstorage
Array.from(document.getElementsByClassName('set-display')) document.querySelectorAll('.set-display')
.forEach(t => t.onclick = updateDisplay); .forEach(t => t.onclick = updateDisplay);