mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-05-20 17:28:55 +00:00
Code Issues Projects Releases Wiki Activity

remove unnecessary loop.

Browse source 
ReviewRatings are a subclass and are included in the models.Review block
This commit is contained in:
Matt Lehrer 2023-11-16 20:37:46 +01:00
parent bf81192d73
commit f4da9fbf34
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
bookwyrm/views/books/editions.py
View file

@ -103,17 +103,12 @@ def switch_edition(request):
readthrough.book = new_edition
readthrough.save()
ratings = models.ReviewRating.objects.filter(
book__parent_work=new_edition.parent_work, user=request.user
)
for rating in ratings.all():
rating.book = new_edition
rating.save()
reviews = models.Review.objects.filter(
book__parent_work=new_edition.parent_work, user=request.user
)
for review in reviews.all():
# because ratings are a subclass of reviews,
# this will pick up both ratings and reviews
review.book = new_edition
review.save()