Merge pull request #2857 from bpeel/no-rating

Show “no rating” instead of blank stars if the review has no rating
This commit is contained in:
Mouse Reeve 2023-05-30 10:42:09 -07:00 committed by GitHub
commit d251f4201b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 22 deletions

View file

@ -5,6 +5,10 @@
white-space: nowrap; white-space: nowrap;
} }
.stars .no-rating {
font-style: italic;
}
/** Stars in a review form /** Stars in a review form
* *
* Specificity makes hovering taking over checked inputs. * Specificity makes hovering taking over checked inputs.

View file

@ -190,6 +190,7 @@
<meta itemprop="bestRating" content="5"> <meta itemprop="bestRating" content="5">
<meta itemprop="reviewCount" content="{{ review_count }}"> <meta itemprop="reviewCount" content="{{ review_count }}">
<span>
{% include 'snippets/stars.html' with rating=rating %} {% include 'snippets/stars.html' with rating=rating %}
{% blocktrans count counter=review_count trimmed %} {% blocktrans count counter=review_count trimmed %}
@ -197,6 +198,7 @@
{% plural %} {% plural %}
({{ review_count }} reviews) ({{ review_count }} reviews)
{% endblocktrans %} {% endblocktrans %}
</span>
</div> </div>
{% with full=book|book_description itemprop='abstract' %} {% with full=book|book_description itemprop='abstract' %}

View file

@ -2,18 +2,14 @@
{% load i18n %} {% load i18n %}
<span class="stars"> <span class="stars">
<span class="is-sr-only">
{% if rating %} {% if rating %}
<span class="is-sr-only">
{% blocktranslate trimmed with rating=rating|floatformat:0 count counter=rating|floatformat:0|add:0 %} {% blocktranslate trimmed with rating=rating|floatformat:0 count counter=rating|floatformat:0|add:0 %}
{{ rating }} star {{ rating }} star
{% plural %} {% plural %}
{{ rating }} stars {{ rating }} stars
{% endblocktranslate %} {% endblocktranslate %}
{% else %}
{% trans "No rating" %}
{% endif %}
</span> </span>
{% for i in '12345'|make_list %} {% for i in '12345'|make_list %}
<span <span
class=" class="
@ -23,5 +19,8 @@
aria-hidden="true" aria-hidden="true"
></span> ></span>
{% endfor %} {% endfor %}
{% else %}
<span class="no-rating">{% trans "No rating" %}</span>
{% endif %}
</span> </span>
{% endspaceless %} {% endspaceless %}