Fixes unit tests

This commit is contained in:
Mouse Reeve 2021-04-30 10:16:24 -07:00
parent 62884c6111
commit ca12359bee

View file

@ -6,6 +6,7 @@ from PIL import Image
from django.contrib.auth.models import AnonymousUser from django.contrib.auth.models import AnonymousUser
from django.core.files.base import ContentFile from django.core.files.base import ContentFile
from django.core.files.uploadedfile import SimpleUploadedFile from django.core.files.uploadedfile import SimpleUploadedFile
from django.http.response import Http404
from django.template.response import TemplateResponse from django.template.response import TemplateResponse
from django.test import TestCase from django.test import TestCase
from django.test.client import RequestFactory from django.test.client import RequestFactory
@ -76,8 +77,8 @@ class UserViews(TestCase):
self.rat.blocks.add(self.local_user) self.rat.blocks.add(self.local_user)
with patch("bookwyrm.views.user.is_api_request") as is_api: with patch("bookwyrm.views.user.is_api_request") as is_api:
is_api.return_value = False is_api.return_value = False
result = view(request, "rat") with self.assertRaises(Http404):
self.assertEqual(result.status_code, 404) view(request, "rat")
def test_followers_page(self): def test_followers_page(self):
"""there are so many views, this just makes sure it LOADS""" """there are so many views, this just makes sure it LOADS"""
@ -105,8 +106,8 @@ class UserViews(TestCase):
self.rat.blocks.add(self.local_user) self.rat.blocks.add(self.local_user)
with patch("bookwyrm.views.user.is_api_request") as is_api: with patch("bookwyrm.views.user.is_api_request") as is_api:
is_api.return_value = False is_api.return_value = False
result = view(request, "rat") with self.assertRaises(Http404):
self.assertEqual(result.status_code, 404) view(request, "rat")
def test_following_page(self): def test_following_page(self):
"""there are so many views, this just makes sure it LOADS""" """there are so many views, this just makes sure it LOADS"""
@ -166,7 +167,6 @@ class UserViews(TestCase):
self.assertEqual(self.local_user.name, "New Name") self.assertEqual(self.local_user.name, "New Name")
self.assertEqual(self.local_user.email, "wow@email.com") self.assertEqual(self.local_user.email, "wow@email.com")
# idk how to mock the upload form, got tired of triyng to make it work
def test_edit_user_avatar(self): def test_edit_user_avatar(self):
"""use a form to update a user""" """use a form to update a user"""
view = views.EditUser.as_view() view = views.EditUser.as_view()