mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2025-01-08 16:25:27 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2235 from bookwyrm-social/fix-rating

Browse source 
Fix ratings
This commit is contained in:
Mouse Reeve 2022-07-17 20:08:10 -07:00 committed by GitHub
commit c2fb076add
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bookwyrm/models/status.py
View file

@ -218,7 +218,8 @@ class Status(OrderedCollectionPageMixin, BookWyrmModel):
"""certain types of status aren't editable"""
# first, the standard raise
super().raise_not_editable(viewer)
if isinstance(self, (GeneratedNote, ReviewRating)):
# if it's an edit (not a create) you can only edit content statuses
if self.id and isinstance(self, (GeneratedNote, ReviewRating)):
raise PermissionDenied()
@classmethod

22
bookwyrm/tests/views/test_status.py
View file

@ -76,6 +76,28 @@ class StatusViews(TestCase):
self.assertEqual(status.book, self.book)
self.assertIsNone(status.edited_date)
def test_create_status_rating(self, *_):
"""create a status"""
view = views.CreateStatus.as_view()
form = forms.RatingForm(
{
"user": self.local_user.id,
"rating": 4,
"book": self.book.id,
"privacy": "public",
}
)
request = self.factory.post("", form.data)
request.user = self.local_user
view(request, "rating")
status = models.ReviewRating.objects.get()
self.assertEqual(status.user, self.local_user)
self.assertEqual(status.book, self.book)
self.assertEqual(status.rating, 4.0)
self.assertIsNone(status.edited_date)
def test_create_status_wrong_user(self, *_):
"""You can't compose statuses for someone else"""
view = views.CreateStatus.as_view()