mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-09-25 13:00:13 +00:00
Code Issues Projects Releases Wiki Activity

Python formatting

Browse source
This commit is contained in:
Mouse Reeve 2021-11-14 07:11:48 -08:00
parent 66ad8c3b25
commit bdc3f6828b
3 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bookwyrm/importers/librarything_import.py
View file

@ -13,10 +13,8 @@ class LibrarythingImporter(Importer):
def normalize_row(self, entry, mappings): # pylint: disable=no-self-use def normalize_row(self, entry, mappings): # pylint: disable=no-self-use
"""use the dataclass to create the formatted row of data""" """use the dataclass to create the formatted row of data"""
remove_brackets = lambda v: re.sub(r"\[|\]", "", v) if v else None remove_brackets = lambda v: re.sub(r"\[|\]", "", v) if v else None
normalized = { normalized = {k: remove_brackets(entry.get(v)) for k, v in mappings.items()}
k: remove_brackets(entry.get(v)) for k, v in mappings.items() isbn_13 = normalized["isbn_13"].split(", ")
}
isbn_13 = normalized["isbn_13"].split(', ')
normalized["isbn_13"] = isbn_13[1] if len(isbn_13) > 0 else None normalized["isbn_13"] = isbn_13[1] if len(isbn_13) > 0 else None
return normalized return normalized

4
bookwyrm/models/import_job.py
View file

@ -127,7 +127,9 @@ class ImportItem(models.Model):
@property @property
def isbn(self): def isbn(self):
"""pulls out the isbn13 field from the csv line data""" """pulls out the isbn13 field from the csv line data"""
return unquote_string(self.normalized_data["isbn_13"]) or unquote_string(self.normalized_data["isbn_10"]) return unquote_string(self.normalized_data["isbn_13"]) or unquote_string(
self.normalized_data["isbn_10"]
)
@property @property
def shelf(self): def shelf(self):

4
bookwyrm/tests/importers/test_goodreads_import.py
View file

@ -52,9 +52,7 @@ class GoodreadsImport(TestCase):
self.assertEqual(len(import_items), 3) self.assertEqual(len(import_items), 3)
self.assertEqual(import_items[0].index, 0) self.assertEqual(import_items[0].index, 0)
self.assertEqual(import_items[0].data["Book Id"], "42036538") self.assertEqual(import_items[0].data["Book Id"], "42036538")
self.assertEqual( self.assertEqual(import_items[0].normalized_data["isbn_13"], '="9781250313195"')
import_items[0].normalized_data["isbn_13"], '="9781250313195"'
)
self.assertEqual(import_items[0].normalized_data["isbn_10"], '="1250313198"') self.assertEqual(import_items[0].normalized_data["isbn_10"], '="1250313198"')
self.assertEqual(import_items[1].index, 1) self.assertEqual(import_items[1].index, 1)