mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-11-25 11:01:12 +00:00
Code Issues Projects Releases Wiki Activity

Uses much simpler approach to ensuring test result order

Browse source
This commit is contained in:
Mouse Reeve 2024-08-26 11:33:01 -07:00
parent 9f5ca7ae60
commit bd773f41c7
1 changed files with 21 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
bookwyrm/tests/importers/test_importer.py
View file

@ -63,30 +63,29 @@ class GenericImporter(TestCase):
self.assertEqual(import_job.include_reviews, False) self.assertEqual(import_job.include_reviews, False)
self.assertEqual(import_job.privacy, "public") self.assertEqual(import_job.privacy, "public")
import_items = models.ImportItem.objects.filter(job=import_job).all() import_items = (
models.ImportItem.objects.filter(job=import_job).all().order_by("id")
)
self.assertEqual(len(import_items), 4) self.assertEqual(len(import_items), 4)
self.assertEqual(import_items[0].index, 0)
self.assertEqual(import_items[0].normalized_data["id"], "38")
self.assertEqual(import_items[0].normalized_data["title"], "Gideon the Ninth")
self.assertEqual(import_items[0].normalized_data["authors"], "Tamsyn Muir")
self.assertEqual(import_items[0].normalized_data["isbn_13"], "9781250313195")
self.assertIsNone(import_items[0].normalized_data["isbn_10"])
self.assertEqual(import_items[0].normalized_data["shelf"], "read")
# items don't get added in a predictable order, so we're using this weird loop self.assertEqual(import_items[1].index, 1)
for item in import_items: self.assertEqual(import_items[1].normalized_data["id"], "48")
if item.index == 0: self.assertEqual(import_items[1].normalized_data["title"], "Harrow the Ninth")
self.assertEqual(item.normalized_data["id"], "38")
self.assertEqual(item.normalized_data["title"], "Gideon the Ninth") self.assertEqual(import_items[2].index, 2)
self.assertEqual(item.normalized_data["authors"], "Tamsyn Muir") self.assertEqual(import_items[2].normalized_data["id"], "23")
self.assertEqual(item.normalized_data["isbn_13"], "9781250313195") self.assertEqual(import_items[2].normalized_data["title"], "Subcutanean")
self.assertIsNone(item.normalized_data["isbn_10"])
self.assertEqual(item.normalized_data["shelf"], "read") self.assertEqual(import_items[3].index, 3)
elif item.index == 1: self.assertEqual(import_items[3].normalized_data["id"], "10")
self.assertEqual(item.index, 1) self.assertEqual(import_items[3].normalized_data["title"], "Patisserie at Home")
self.assertEqual(item.normalized_data["id"], "48")
self.assertEqual(item.normalized_data["title"], "Harrow the Ninth")
elif item.index == 2:
self.assertEqual(item.index, 2)
self.assertEqual(item.normalized_data["id"], "23")
self.assertEqual(item.normalized_data["title"], "Subcutanean")
elif item.index == 3:
self.assertEqual(item.index, 3)
self.assertEqual(item.normalized_data["id"], "10")
self.assertEqual(item.normalized_data["title"], "Patisserie at Home")
def test_create_retry_job(self, *_): def test_create_retry_job(self, *_):
"""trying again with items that didn't import""" """trying again with items that didn't import"""