mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-12-23 08:36:32 +00:00
Code Issues Projects Releases Wiki Activity

Use None instead of empty dict for endpoint default value

Browse source
This commit is contained in:
Mouse Reeve 2021-03-17 13:59:16 -07:00
parent 0d8e1f0ae2
commit ba09377041
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bookwyrm/activitypub/person.py
View file

@ -24,7 +24,7 @@ class Person(ActivityObject):
outbox: str
followers: str
publicKey: PublicKey
endpoints: Dict = field(default_factory=lambda: {})
endpoints: Dict = None
name: str = None
summary: str = None
icon: Image = field(default_factory=lambda: {})

4
bookwyrm/models/fields.py
View file

@ -73,7 +73,7 @@ class ActivitypubFieldMixin:
raise
value = getattr(data, "actor")
formatted = self.field_from_activity(value)
if formatted is None or formatted is MISSING:
if formatted is None or formatted is MISSING or formatted == {}:
return
setattr(instance, self.name, formatted)
@ -101,7 +101,7 @@ class ActivitypubFieldMixin:
def field_from_activity(self, value):
""" formatter to convert activitypub into a model value """
if hasattr(self, "activitypub_wrapper"):
if value and hasattr(self, "activitypub_wrapper"):
value = value.get(self.activitypub_wrapper)
return value