mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-11-27 03:51:08 +00:00
Code Issues Projects Releases Wiki Activity

Updates fragile unit test causing nondeterministic failures

Browse source
This commit is contained in:
Mouse Reeve 2022-01-04 11:35:12 -08:00
parent cccd28cb74
commit 9dd2b88054
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bookwyrm/tests/models/test_fields.py
View file

@ -483,7 +483,6 @@ class ModelFields(TestCase):
instance.set_field_from_activity(book, mock_activity) instance.set_field_from_activity(book, mock_activity)
self.assertIsNotNone(book.cover.name) self.assertIsNotNone(book.cover.name)
self.assertEqual(book.cover.size, 43200)
@responses.activate @responses.activate
def test_image_field_set_field_from_activity_no_overwrite_no_cover(self, *_): def test_image_field_set_field_from_activity_no_overwrite_no_cover(self, *_):
@ -510,7 +509,6 @@ class ModelFields(TestCase):
instance.set_field_from_activity(book, mock_activity, overwrite=False) instance.set_field_from_activity(book, mock_activity, overwrite=False)
self.assertIsNotNone(book.cover.name) self.assertIsNotNone(book.cover.name)
self.assertEqual(book.cover.size, 43200)
@responses.activate @responses.activate
def test_image_field_set_field_from_activity_no_overwrite_with_cover(self, *_): def test_image_field_set_field_from_activity_no_overwrite_with_cover(self, *_):
@ -539,14 +537,15 @@ class ModelFields(TestCase):
) )
book = Edition.objects.create(title="hello") book = Edition.objects.create(title="hello")
book.cover.save("test.jpg", ContentFile(output.getvalue())) book.cover.save("test.jpg", ContentFile(output.getvalue()))
self.assertEqual(book.cover.size, 2136) cover_size = book.cover.size
self.assertIsNotNone(cover_size)
MockActivity = namedtuple("MockActivity", ("cover")) MockActivity = namedtuple("MockActivity", ("cover"))
mock_activity = MockActivity("http://www.example.com/image.jpg") mock_activity = MockActivity("http://www.example.com/image.jpg")
instance.set_field_from_activity(book, mock_activity, overwrite=False) instance.set_field_from_activity(book, mock_activity, overwrite=False)
# same cover as before # same cover as before
self.assertEqual(book.cover.size, 2136) self.assertEqual(book.cover.size, cover_size)
@responses.activate @responses.activate
def test_image_field_set_field_from_activity_with_overwrite_with_cover(self, *_): def test_image_field_set_field_from_activity_with_overwrite_with_cover(self, *_):
@ -559,7 +558,8 @@ class ModelFields(TestCase):
image.save(output, format=image.format) image.save(output, format=image.format)
book = Edition.objects.create(title="hello") book = Edition.objects.create(title="hello")
book.cover.save("test.jpg", ContentFile(output.getvalue())) book.cover.save("test.jpg", ContentFile(output.getvalue()))
self.assertEqual(book.cover.size, 2136) cover_size = book.cover.size
self.assertIsNotNone(cover_size)
another_image_file = pathlib.Path(__file__).parent.joinpath( another_image_file = pathlib.Path(__file__).parent.joinpath(
"../../static/images/logo.png" "../../static/images/logo.png"
@ -583,7 +583,7 @@ class ModelFields(TestCase):
instance.set_field_from_activity(book, mock_activity, overwrite=True) instance.set_field_from_activity(book, mock_activity, overwrite=True)
# new cover # new cover
self.assertIsNotNone(book.cover.name) self.assertIsNotNone(book.cover.name)
self.assertEqual(book.cover.size, 376800) self.assertFalse(book.cover.size, cover_size)
def test_datetime_field(self, *_): def test_datetime_field(self, *_):
"""this one is pretty simple, it just has to use isoformat""" """this one is pretty simple, it just has to use isoformat"""