mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2025-01-07 07:45:28 +00:00
Code Issues Projects Releases Wiki Activity

Catches some stray unvalidated html in landing tests

Browse source
This commit is contained in:
Mouse Reeve 2021-10-16 12:03:42 -07:00
parent c852405e42
commit 8bdedc9304
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bookwyrm/tests/views/landing/test_login.py
View file

@ -7,6 +7,7 @@ from django.test import TestCase
from django.test.client import RequestFactory from django.test.client import RequestFactory
from bookwyrm import forms, models, views from bookwyrm import forms, models, views
from bookwyrm.tests.validate_html import validate_html
# pylint: disable=too-many-public-methods # pylint: disable=too-many-public-methods
@ -41,7 +42,7 @@ class LoginViews(TestCase):
result = login(request) result = login(request)
self.assertIsInstance(result, TemplateResponse) self.assertIsInstance(result, TemplateResponse)
result.render() validate_html(result.render())
self.assertEqual(result.status_code, 200) self.assertEqual(result.status_code, 200)
request.user = self.local_user request.user = self.local_user
@ -102,7 +103,7 @@ class LoginViews(TestCase):
with patch("bookwyrm.views.landing.login.login"): with patch("bookwyrm.views.landing.login.login"):
result = view(request) result = view(request)
result.render() validate_html(result.render())
self.assertEqual(result.status_code, 200) self.assertEqual(result.status_code, 200)
self.assertEqual( self.assertEqual(
result.context_data["login_form"].non_field_errors, result.context_data["login_form"].non_field_errors,

8
bookwyrm/tests/views/landing/test_password.py
View file

@ -51,13 +51,13 @@ class PasswordViews(TestCase):
view = views.PasswordResetRequest.as_view() view = views.PasswordResetRequest.as_view()
resp = view(request) resp = view(request)
self.assertEqual(resp.status_code, 200) self.assertEqual(resp.status_code, 200)
resp.render() validate_html(resp.render())
request = self.factory.post("", {"email": "mouse@mouse.com"}) request = self.factory.post("", {"email": "mouse@mouse.com"})
request.user = self.anonymous_user request.user = self.anonymous_user
with patch("bookwyrm.emailing.send_email.delay"): with patch("bookwyrm.emailing.send_email.delay"):
resp = view(request) resp = view(request)
resp.render() validate_html(resp.render())
self.assertEqual(models.PasswordReset.objects.get().user, self.local_user) self.assertEqual(models.PasswordReset.objects.get().user, self.local_user)
@ -116,7 +116,7 @@ class PasswordViews(TestCase):
models.PasswordReset.objects.create(user=self.local_user) models.PasswordReset.objects.create(user=self.local_user)
request = self.factory.post("", {"password": "hi", "confirm-password": "hi"}) request = self.factory.post("", {"password": "hi", "confirm-password": "hi"})
resp = view(request, "jhgdkfjgdf") resp = view(request, "jhgdkfjgdf")
resp.render() validate_html(resp.render())
self.assertTrue(models.PasswordReset.objects.exists()) self.assertTrue(models.PasswordReset.objects.exists())
def test_password_reset_mismatch(self): def test_password_reset_mismatch(self):
@ -125,5 +125,5 @@ class PasswordViews(TestCase):
code = models.PasswordReset.objects.create(user=self.local_user) code = models.PasswordReset.objects.create(user=self.local_user)
request = self.factory.post("", {"password": "hi", "confirm-password": "hihi"}) request = self.factory.post("", {"password": "hi", "confirm-password": "hihi"})
resp = view(request, code.code) resp = view(request, code.code)
resp.render() validate_html(resp.render())
self.assertTrue(models.PasswordReset.objects.exists()) self.assertTrue(models.PasswordReset.objects.exists())