mirrors/bookwyrm
1
0
Fork 1
mirror of https://github.com/bookwyrm-social/bookwyrm.git synced 2024-09-25 04:50:04 +00:00
Code Issues Projects Releases Wiki Activity

[assets] Update interactions code:

Browse source 
This commit should address https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609381969.

- Disable the button being used to submit the form.
- Rename variables based on @mouse-reeve’s explanations. Thanks! ✨
This commit is contained in:
Fabien Basmaison 2021-04-08 11:08:13 +02:00
parent ad3e91db7d
commit 83bd417878
1 changed files with 22 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
bookwyrm/static/js/bookwyrm.js
View file

@ -229,7 +229,7 @@ let BookWyrm = new class {
/**
* Make a request and update the UI accordingly.
* This function is used for boosts and favourites.
* This function is used for boosts, favourites, follows and unfollows.
*
* @param {Event} event
* @return {undefined}
@ -238,30 +238,32 @@ let BookWyrm = new class {
event.preventDefault();
const bookwyrm = this;
let allTriggers = document.querySelectorAll(`.${event.target.dataset.id}`);
const trigger = event.submitter;
const target = event.currentTarget;
const forms = document.querySelectorAll(`.${target.dataset.id}`);
// Change icon to show ongoing activity on the current UI.
allTriggers.forEach(node => bookwyrm.addRemoveClass(
node,
'is-processing',
true
));
// Disable the element used to submit the form to prevent duplicated requests.
// @todo Ideally, disable all potential ways to submit this specific form.
forms.forEach(form => {
bookwyrm.addRemoveClass(form, 'is-processing', true);
trigger.setAttribute('disabled', null);
});
this.ajaxPost(event.target)
this.ajaxPost(target)
.finally(() => {
// Change icon to remove ongoing activity on the current UI.
allTriggers.forEach(node => bookwyrm.addRemoveClass(
node,
'is-processing',
false
));
// Enable back the element used to submit the form.
forms.forEach(form => {
bookwyrm.addRemoveClass(form, 'is-processing', false);
trigger.removeAttribute('disabled');
});
})
.then(function() {
allTriggers.forEach(node => bookwyrm.addRemoveClass(
node,
forms.forEach(form => bookwyrm.addRemoveClass(
form,
'is-hidden',
node.className.indexOf('is-hidden') == -1
form.className.indexOf('is-hidden') == -1
));
})
.catch(error => {
@ -269,10 +271,10 @@ let BookWyrm = new class {
// For now, the absence of change will be enough.
console.warn('Request failed:', error);
allTriggers.forEach(node => bookwyrm.addRemoveClass(
node,
forms.forEach(form => bookwyrm.addRemoveClass(
form,
'has-error',
node.className.indexOf('is-hidden') == -1
form.className.indexOf('is-hidden') == -1
));
});
}