javascript cleanup

I got my linter working!
This commit is contained in:
Mouse Reeve 2021-01-18 08:26:04 -08:00
parent d6f2740bc8
commit 7308d8d1e9

View file

@ -1,6 +1,6 @@
// set up javascript listeners // set up javascript listeners
window.onload = function() { window.onload = function() {
// let buttons set keyboard focus // buttons that display or hide content
document.querySelectorAll('[data-controls]') document.querySelectorAll('[data-controls]')
.forEach(t => t.onclick = toggleAction); .forEach(t => t.onclick = toggleAction);
@ -30,6 +30,7 @@ window.onload = function() {
}; };
function updateDisplay(e) { function updateDisplay(e) {
// used in set reading goal
var key = e.target.getAttribute('data-id'); var key = e.target.getAttribute('data-id');
var value = e.target.getAttribute('data-value'); var value = e.target.getAttribute('data-value');
window.localStorage.setItem(key, value); window.localStorage.setItem(key, value);
@ -39,13 +40,10 @@ function updateDisplay(e) {
} }
function setDisplay(el) { function setDisplay(el) {
// used in set reading goal
var key = el.getAttribute('data-hide'); var key = el.getAttribute('data-hide');
var value = window.localStorage.getItem(key) var value = window.localStorage.getItem(key);
if (!value) { addRemoveClass(el, 'hidden', value);
el.className = el.className.replace('hidden', '');
} else if (value != null && !!value) {
el.className += ' hidden';
}
} }
@ -55,7 +53,7 @@ function toggleAction(e) {
var targetId = el.getAttribute('data-controls'); var targetId = el.getAttribute('data-controls');
document.querySelectorAll('[data-controls="' + targetId + '"]') document.querySelectorAll('[data-controls="' + targetId + '"]')
.forEach(t => t.setAttribute('aria-pressed', !!(t.getAttribute('aria-pressed') == 'false'))); .forEach(t => t.setAttribute('aria-pressed', (t.getAttribute('aria-pressed') == 'false')));
if (targetId) { if (targetId) {
var target = document.getElementById(targetId); var target = document.getElementById(targetId);
@ -82,48 +80,12 @@ function toggleAction(e) {
} }
} }
function addRemoveClass(el, classname, bool) {
if (bool) {
addClass(el, classname)
} else {
removeClass(el, classname)
}
}
function addClass(el, classname) {
var classes = el.className.split(' ');
if (classes.indexOf(classname) > -1) {
return
}
el.className = classes.concat(classname).join(' ');
}
function removeClass(el, className) {
var classes = []
if (el.className) {
var classes = el.className.split(' ');
}
const idx = classes.indexOf(className);
if (idx > -1) {
classes.splice(idx, 1);
}
el.className = classes.join(' ');
}
function interact(e) { function interact(e) {
e.preventDefault(); e.preventDefault();
ajaxPost(e.target); ajaxPost(e.target);
var identifier = e.target.getAttribute('data-id'); var identifier = e.target.getAttribute('data-id');
var elements = document.getElementsByClassName(identifier); Array.from(document.getElementsByClassName(identifier))
for (var i = 0; i < elements.length; i++) { .forEach(t => addRemoveClass(t, 'hidden', t.className.indexOf('hidden') == -1));
if (elements[i].className.includes('hidden')) {
elements[i].className = elements[i].className.replace('hidden', '');
} else {
elements[i].className += ' hidden';
}
}
return true;
} }
function selectAll(e) { function selectAll(e) {
@ -145,7 +107,7 @@ function tabChange(e) {
var tabId = el.getAttribute('data-tab'); var tabId = el.getAttribute('data-tab');
Array.from(document.getElementsByClassName(el.getAttribute('data-category'))) Array.from(document.getElementsByClassName(el.getAttribute('data-category')))
.forEach(t => addRemoveClass(t, 'hidden', t.id != tabId)) .forEach(t => addRemoveClass(t, 'hidden', t.id != tabId));
} }
function toggleMenu(e) { function toggleMenu(e) {
@ -165,3 +127,31 @@ function ajaxPost(form) {
body: new FormData(form) body: new FormData(form)
}); });
} }
function addRemoveClass(el, classname, bool) {
if (bool) {
addClass(el, classname);
} else {
removeClass(el, classname);
}
}
function addClass(el, classname) {
var classes = el.className.split(' ');
if (classes.indexOf(classname) > -1) {
return;
}
el.className = classes.concat(classname).join(' ');
}
function removeClass(el, className) {
var classes = [];
if (el.className) {
classes = el.className.split(' ');
}
const idx = classes.indexOf(className);
if (idx > -1) {
classes.splice(idx, 1);
}
el.className = classes.join(' ');
}