Apply review suggestions

This commit is contained in:
Joachim 2021-05-24 12:36:48 +02:00
parent 55a3a28d49
commit 58c07d1677

View file

@ -22,7 +22,7 @@
</div> </div>
</div> </div>
<div class="block content columns" itemscope itemtype="https://schema.org/Person"> <div class="block columns" itemscope itemtype="https://schema.org/Person">
<meta itemprop="name" content="{{ author.name }}"> <meta itemprop="name" content="{{ author.name }}">
{% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %} {% if author.aliases or author.born or author.died or author.wikipedia_link or author.openlibrary_key or author.inventaire_id %}
@ -32,11 +32,11 @@
{% if author.aliases %} {% if author.aliases %}
<div class="is-flex"> <div class="is-flex">
<dt class="mr-1">{% trans "Aliases:" %}</dt> <dt class="mr-1">{% trans "Aliases:" %}</dt>
<dd>
{% for alias in author.aliases %} {% for alias in author.aliases %}
<span itemprop="alternateName">{{alias}}</span>{% if not forloop.last %},{% endif %} <dd itemprop="alternateName" content="{{alias}}">
{% endfor %} {{alias}}{% if not forloop.last %},{% endif %}
</dd> </dd>
{% endfor %}
</div> </div>
{% endif %} {% endif %}
{% if author.born %} {% if author.born %}
@ -54,25 +54,24 @@
</dl> </dl>
{% if author.wikipedia_link %} {% if author.wikipedia_link %}
<p> <p class="mt-1">
<link itemprop="sameAs" href="{{ author.wikipedia_link }}" /> <a itemprop="sameAs" href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
<a href="{{ author.wikipedia_link }}" rel=”noopener” target="_blank">
{% trans "Wikipedia" %} {% trans "Wikipedia" %}
</a> </a>
</p> </p>
{% endif %} {% endif %}
{% if author.openlibrary_key %} {% if author.openlibrary_key %}
<p class="mb-0"> <p class="mt-1">
<link itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" /> <a itemprop="sameAs" href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
<a href="https://openlibrary.org/authors/{{ author.openlibrary_key }}" target="_blank" rel="noopener">
{% trans "View on OpenLibrary" %} {% trans "View on OpenLibrary" %}
</a> </a>
</p> </p>
{% endif %} {% endif %}
{% if author.inventaire_id %} {% if author.inventaire_id %}
<p class="mb-0"> <p class="mt-1">
<link itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" /> <a itemprop="sameAs" href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
<a href="https://inventaire.io/entity/{{ author.inventaire_id }}" target="_blank" rel="noopener">
{% trans "View on Inventaire" %} {% trans "View on Inventaire" %}
</a> </a>
</p> </p>