rafaelcaricio/statsd_exporter
1
0
Fork 0
forked from mirrors/statsd_exporter
Code Issues Pull requests Projects Releases Packages Wiki Activity

Ensure we log errors every time there is a problem

Browse source 
Move addition of metric to "Elements" until after a successful registry
with prometheus, otherwise we'll continue to increment a metric which
isn't registered
This commit is contained in:
Thomas Jackson 2017-07-18 08:48:51 -07:00
parent d9aa6e2867
commit c1791d7ecb
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
exporter.go
View file

@ -78,10 +78,10 @@ func (c *CounterContainer) Get(metricName string, labels prometheus.Labels) (pro
Help: defaultHelp, Help: defaultHelp,
ConstLabels: labels, ConstLabels: labels,
}) })
c.Elements[hash] = counter
if err := prometheus.Register(counter); err != nil { if err := prometheus.Register(counter); err != nil {
return nil, err return nil, err
} }
c.Elements[hash] = counter
} }
return counter, nil return counter, nil
} }
@ -105,10 +105,10 @@ func (c *GaugeContainer) Get(metricName string, labels prometheus.Labels) (prome
Help: defaultHelp, Help: defaultHelp,
ConstLabels: labels, ConstLabels: labels,
}) })
c.Elements[hash] = gauge
if err := prometheus.Register(gauge); err != nil { if err := prometheus.Register(gauge); err != nil {
return nil, err return nil, err
} }
c.Elements[hash] = gauge
} }
return gauge, nil return gauge, nil
} }
@ -133,10 +133,10 @@ func (c *SummaryContainer) Get(metricName string, labels prometheus.Labels) (pro
Help: defaultHelp, Help: defaultHelp,
ConstLabels: labels, ConstLabels: labels,
}) })
c.Elements[hash] = summary
if err := prometheus.Register(summary); err != nil { if err := prometheus.Register(summary); err != nil {
return nil, err return nil, err
} }
c.Elements[hash] = summary
} }
return summary, nil return summary, nil
} }