rafaelcaricio/lvgl-rs
1
0
Fork 0
Code Issues 12 Pull requests 2 Projects Releases 4 Wiki Activity

Rust bindings API review #51

Open
rafaelcaricio wants to merge 19 commits from api-review into master
pull from: api-review
merge into: rafaelcaricio:master
Conversation 0 Commits 19 Files changed 18 +16 -9
1 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f9ef4badb8 - Show all commits

23
examples/app.rs
View file

@ -2,8 +2,8 @@ use embedded_graphics::pixelcolor::Rgb565;
use embedded_graphics::prelude::*; use embedded_graphics::prelude::*;
use embedded_graphics_simulator::{OutputSettingsBuilder, SimulatorDisplay, Window}; use embedded_graphics_simulator::{OutputSettingsBuilder, SimulatorDisplay, Window};
use lvgl; use lvgl;
use lvgl::display::Display;
use lvgl::widgets::Label; use lvgl::widgets::Label;
use lvgl::{Display, DrawBuffer};
use parking_lot::Mutex; use parking_lot::Mutex;
use std::cell::RefCell; use std::cell::RefCell;
use std::sync::Arc; use std::sync::Arc;
@ -12,8 +12,8 @@ type ColorSpace = Rgb565;
fn main() { fn main() {
let embedded_graphics_display: SimulatorDisplay<ColorSpace> = SimulatorDisplay::new(Size::new( let embedded_graphics_display: SimulatorDisplay<ColorSpace> = SimulatorDisplay::new(Size::new(
lvgl_sys::LV_HOR_RES_MAX, lvgl::DISP_HOR_RES as u32,
lvgl_sys::LV_VER_RES_MAX, lvgl::DISP_VER_RES as u32,
)); ));
let output_settings = OutputSettingsBuilder::new().scale(2).build(); let output_settings = OutputSettingsBuilder::new().scale(2).build();
@ -23,11 +23,18 @@ fn main() {
// LVGL usage // LVGL usage
lvgl::init(); lvgl::init();
let display = Display::register_shared(&shared_native_display).unwrap();
let label = Label::new().unwrap();
{ const REFRESH_BUFFER_SIZE: usize = lvgl::DISP_HOR_RES * lvgl::DISP_VER_RES / 10;
let mut val = shared_native_display.lock(); static DRAW_BUFFER: DrawBuffer<REFRESH_BUFFER_SIZE> = DrawBuffer::new();
rafaelcaricio commented 2021-06-08 20:53:27 +00:00 (Migrated from github.com)
Review
Copy link

Making this statically allocated will avoid dropping this memory address by mistake in an app code.

Making this statically allocated will avoid dropping this memory address by mistake in an app code.
val.draw_pixel(Pixel::default()).unwrap();
let display = Display::register(&DRAW_BUFFER, {
let shared_display = Arc::clone(&shared_native_display);
move |update| {
let mut embedded_graphics_display = shared_display.lock();
embedded_graphics_display.draw_iter(update.as_pixels());
} }
})
.unwrap();
let label: Label = "Nice!".into();
} }