Fails when radial-gradient shape is omitted but a size is provided #4

New issue

Closed

opened 2015-07-21 07:50:29 +00:00 by gilmoreorless · 3 comments

gilmoreorless commented

2015-07-21 07:50:29 +00:00

(Migrated from github.com)

The radial-gradient spec says that both shape and size are optional.

Gradient Parser works with most cases, but it fails in the specific case when a size is given (such as "furthest-corner") but a shape is omitted.

Example: https://jsbin.com/gogelo/5/edit?html,js,console

The [radial-gradient spec](http://www.w3.org/TR/css3-images/#radial-gradients) says that both _shape_ and _size_ are optional. Gradient Parser works with most cases, but it fails in the specific case when a size is given (such as "furthest-corner") but a shape is omitted. Example: https://jsbin.com/gogelo/5/edit?html,js,console

rafaelcaricio commented

2016-01-10 12:31:39 +00:00

(Migrated from github.com)

Thank you for pointing this out and sorry for the very late fix.

pixelspark commented

2021-01-25 17:33:46 +00:00

(Migrated from github.com)

@rafaelcaricio it looks like the built version was not updated: the error still exists in https://github.com/rafaelcaricio/gradient-parser/blob/master/build/node.js#L267. Would you mind updating the build as well?

👀 1

rafaelcaricio commented

2021-01-26 16:25:09 +00:00

(Migrated from github.com)