test: fix test to properly pass in invalid inputs individually

This commit is contained in:
Tom French 2022-05-09 11:31:07 +01:00 committed by James Long
parent 8ae21c9782
commit c66c316b95

View file

@ -24,7 +24,7 @@ describe('Timestamp', function() {
describe('parsing', function() { describe('parsing', function() {
it('should not parse', function() { it('should not parse', function() {
var invalid = [ const invalidInputs = [
null, null,
undefined, undefined,
{}, {},
@ -40,26 +40,26 @@ describe('Timestamp', function() {
'9999-12-31T23:59:59.999Z-10000-FFFFFFFFFFFFFFFF', '9999-12-31T23:59:59.999Z-10000-FFFFFFFFFFFFFFFF',
'9999-12-31T23:59:59.999Z-FFFF-10000000000000000' '9999-12-31T23:59:59.999Z-FFFF-10000000000000000'
]; ];
for (var i = 0; i < invalid.length; i++) { for (const invalidInput of invalidInputs) {
expect(Timestamp.parse(invalid)).toBe(null); expect(Timestamp.parse(invalidInput)).toBe(null);
} }
}); });
it('should parse', function() { it('should parse', function() {
var valid = [ var validInputs = [
'1970-01-01T00:00:00.000Z-0000-0000000000000000', '1970-01-01T00:00:00.000Z-0000-0000000000000000',
'2015-04-24T22:23:42.123Z-1000-0123456789ABCDEF', '2015-04-24T22:23:42.123Z-1000-0123456789ABCDEF',
'9999-12-31T23:59:59.999Z-FFFF-FFFFFFFFFFFFFFFF' '9999-12-31T23:59:59.999Z-FFFF-FFFFFFFFFFFFFFFF'
]; ];
for (var i = 0; i < valid.length; i++) { for (const validInput of validInputs) {
var parsed = Timestamp.parse(valid[i]); var parsed = Timestamp.parse(validInput);
expect(typeof parsed).toBe('object'); expect(typeof parsed).toBe('object');
expect(parsed.millis() >= 0).toBeTruthy(); expect(parsed.millis() >= 0).toBeTruthy();
expect(parsed.millis() < 253402300800000).toBeTruthy(); expect(parsed.millis() < 253402300800000).toBeTruthy();
expect(parsed.counter() >= 0).toBeTruthy(); expect(parsed.counter() >= 0).toBeTruthy();
expect(parsed.counter() < 65536).toBeTruthy(); expect(parsed.counter() < 65536).toBeTruthy();
expect(typeof parsed.node()).toBe('string'); expect(typeof parsed.node()).toBe('string');
expect(parsed.toString()).toBe(valid[i]); expect(parsed.toString()).toBe(validInput);
} }
}); });
}); });