Switch to preserving username case

Except on comparisons, for now. Fixes #224

activities/services/search.py

@@ -13,7 +13,7 @@ class SearchService:
     """
 
     def __init__(self, query: str, identity: Identity | None):
-        self.query = query.strip().lower()
+        self.query = query.strip()
         self.identity = identity
 
     def search_identities_handle(self) -> set[Identity]:
@@ -26,7 +26,7 @@ class SearchService:
             return set()
 
         # Try to fetch the user by handle
-        handle = self.query.lstrip("@")
+        handle = self.query.lstrip("@").lower()
         results: set[Identity] = set()
         if "@" in handle:
             username, domain = handle.split("@", 1)
@@ -37,7 +37,8 @@ class SearchService:
                 if domain_instance is None:
                     raise Identity.DoesNotExist()
                 identity = Identity.objects.get(
-                    domain=domain_instance, username=username
+                    domain=domain_instance,
+                    username__iexact=username,
                 )
             except Identity.DoesNotExist:
                 if self.identity is not None:
@@ -82,11 +83,13 @@ class SearchService:
         type = document.get("type", "unknown").lower()
 
         # Is it an identity?
+        print(type)
         if type in Identity.ACTOR_TYPES:
             # Try and retrieve the profile by actor URI
             identity = Identity.by_actor_uri(document["id"], create=True)
+            print("got identity")
             if identity and identity.state == IdentityStates.outdated:
-                async_to_sync(identity.fetch_actor)()
+                print(async_to_sync(identity.fetch_actor)())
             return identity
 
         # Is it a post?
@@ -112,7 +115,7 @@ class SearchService:
             return set()
 
         results: set[Hashtag] = set()
-        name = self.query.lstrip("#")
+        name = self.query.lstrip("#").lower()
         for hashtag in Hashtag.objects.public().hashtag_or_alias(name)[:10]:
             results.add(hashtag)
         for hashtag in Hashtag.objects.public().filter(hashtag__startswith=name)[:10]:

users/models/identity.py

@@ -293,18 +293,17 @@ class Identity(StatorModel):
     def by_username_and_domain(cls, username, domain, fetch=False, local=False):
         if username.startswith("@"):
             raise ValueError("Username must not start with @")
-        username = username.lower()
         domain = domain.lower()
         try:
             if local:
                 return cls.objects.get(
-                    username=username,
+                    username__iexact=username,
                     domain_id=domain,
                     local=True,
                 )
             else:
                 return cls.objects.get(
-                    username=username,
+                    username__iexact=username,
                     domain_id=domain,
                 )
         except cls.DoesNotExist:
@@ -596,7 +595,7 @@ class Identity(StatorModel):
         if self.username and "@value" in self.username:
             self.username = self.username["@value"]
         if self.username:
-            self.username = self.username.lower()
+            self.username = self.username
         self.manually_approves_followers = document.get("manuallyApprovesFollowers")
         self.public_key = document.get("publicKey", {}).get("publicKeyPem")
         self.public_key_id = document.get("publicKey", {}).get("id")
@@ -626,7 +625,7 @@ class Identity(StatorModel):
             )
             if webfinger_handle:
                 webfinger_username, webfinger_domain = webfinger_handle.split("@")
-                self.username = webfinger_username.lower()
+                self.username = webfinger_username
                 self.domain = await get_domain(webfinger_domain)
             else:
                 self.domain = await get_domain(actor_url_parts.hostname)

users/views/admin/identities.py

@@ -35,7 +35,7 @@ class IdentitiesRoot(ListView):
             if "@" in query:
                 username, domain = query.split("@", 1)
                 identities = identities.filter(
-                    username=username,
+                    username__iexact=username,
                     domain__domain__istartswith=domain,
                 )
             else:

users/views/identity.py

@@ -285,7 +285,10 @@ class CreateIdentity(FormView):
             if (
                 username
                 and domain
-                and Identity.objects.filter(username=username, domain=domain).exists()
+                and Identity.objects.filter(
+                    username__iexact=username,
+                    domain=domain.lower(),
+                ).exists()
             ):
                 raise forms.ValidationError(f"{username}@{domain} is already taken")
 
@@ -307,7 +310,7 @@ class CreateIdentity(FormView):
         domain_instance = Domain.get_domain(domain)
         new_identity = Identity.objects.create(
             actor_uri=f"https://{domain_instance.uri_domain}/@{username}@{domain}/",
-            username=username.lower(),
+            username=username,
             domain_id=domain,
             name=form.cleaned_data["name"],
             local=True,