mirrors/statsd_exporter
1
0
Fork 1
mirror of https://github.com/prometheus/statsd_exporter.git synced 2024-12-25 15:00:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Replace Split with special purpose implementation

Browse source 
This improves performance from 3169ns/op to 2836 ns/op and drops one
allocation per op.

Signed-off-by: Clayton O'Neill <claytono@github.com>
This commit is contained in:
Clayton O'Neill 2019-05-13 12:10:17 -04:00
parent e3cdd85a09
commit a4faae262b
No known key found for this signature in database
GPG key ID: 5017D45C788B5274
1 changed files with 28 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
exporter.go
View file

@ -584,9 +584,11 @@ func buildEvent(statType, metric string, value float64, relative bool, labels ma
} }
} }
func parseDogStatsDTagToKeyValue(tag string) (k, v string) { func handleDogStatsDTagToKeyValue(labels map[string]string, component, tag string) {
// Bail early if the tag is empty // Bail early if the tag is empty
if len(tag) == 0 { if len(tag) == 0 {
tagErrors.Inc()
log.Debugf("Malformed or empty DogStatsD tag %s in component %s", tag, component)
return return
} }
// Skip hash if found. // Skip hash if found.
@ -595,6 +597,7 @@ func parseDogStatsDTagToKeyValue(tag string) (k, v string) {
} }
// find the first comma and split the tag into key and value. // find the first comma and split the tag into key and value.
var k, v string
for i, c := range tag { for i, c := range tag {
if c == ':' { if c == ':' {
k = tag[0:i] k = tag[0:i]
@ -602,6 +605,15 @@ func parseDogStatsDTagToKeyValue(tag string) (k, v string) {
break break
} }
} }
// If either of them is empty, then either the k or v is empty, or we
// didn't find a colon, either way, throw an error and skip ahead.
if len(k) == 0 || len(v) == 0 {
tagErrors.Inc()
log.Debugf("Malformed or empty DogStatsD tag %s in component %s", tag, component)
return
}
labels[escapeMetricName(k)] = v
return return
} }
@ -609,19 +621,22 @@ func parseDogStatsDTagToKeyValue(tag string) (k, v string) {
func parseDogStatsDTagsToLabels(component string) map[string]string { func parseDogStatsDTagsToLabels(component string) map[string]string {
labels := map[string]string{} labels := map[string]string{}
tagsReceived.Inc() tagsReceived.Inc()
tags := strings.Split(component, ",")
for _, t := range tags { lastTagEndIndex := 0
k, v := parseDogStatsDTagToKeyValue(t) for i, c := range component {
// If either of them is empty, then either the k or v is empty, or we if c == ',' {
// didn't find a colon, either way, throw an error and skip ahead. tag := component[lastTagEndIndex:i]
if len(k) == 0 || len(v) == 0 { lastTagEndIndex = i + 1
tagErrors.Inc() handleDogStatsDTagToKeyValue(labels, component, tag)
log.Debugf("Malformed or empty DogStatsD tag %s in component %s", t, component) }
continue
} }
labels[escapeMetricName(k)] = v // If we're not off the end of the string, add the last tag
if lastTagEndIndex < len(component) {
tag := component[lastTagEndIndex:]
handleDogStatsDTagToKeyValue(labels, component, tag)
} }
return labels return labels
} }
@ -703,7 +718,7 @@ samples:
multiplyEvents = int(1 / samplingFactor) multiplyEvents = int(1 / samplingFactor)
} }
case '#': case '#':
labels = parseDogStatsDTagsToLabels(component) labels = parseDogStatsDTagsToLabels(component[1:])
default: default:
log.Debugf("Invalid sampling factor or tag section %s on line %s", components[2], line) log.Debugf("Invalid sampling factor or tag section %s on line %s", components[2], line)
sampleErrors.WithLabelValues("invalid_sample_factor").Inc() sampleErrors.WithLabelValues("invalid_sample_factor").Inc()