[pylint] Bing (Web) engine

Fix remarks from pylint and improved code-style.  In preparation for a bug-fix
of the Bing (Web) engine I add this engine to the pylint-list.

Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
This commit is contained in:
Markus Heiser 2021-12-18 11:40:12 +01:00
parent 4da1e0026c
commit b2177e5916

View file

@ -1,6 +1,6 @@
# SPDX-License-Identifier: AGPL-3.0-or-later # SPDX-License-Identifier: AGPL-3.0-or-later
""" # lint: pylint
Bing (Web) """Bing (Web)
""" """
import re import re
@ -8,7 +8,6 @@ from urllib.parse import urlencode
from lxml import html from lxml import html
from searx.utils import eval_xpath, extract_text, match_language from searx.utils import eval_xpath, extract_text, match_language
# about
about = { about = {
"website": 'https://www.bing.com', "website": 'https://www.bing.com',
"wikidata_id": 'Q182496', "wikidata_id": 'Q182496',
@ -21,6 +20,8 @@ about = {
# engine dependent config # engine dependent config
categories = ['general'] categories = ['general']
paging = True paging = True
time_range_support = False
safesearch = False
supported_languages_url = 'https://www.bing.com/account/general' supported_languages_url = 'https://www.bing.com/account/general'
language_aliases = {'zh-CN': 'zh-CHS', 'zh-TW': 'zh-CHT', 'zh-HK': 'zh-CHT'} language_aliases = {'zh-CN': 'zh-CHS', 'zh-TW': 'zh-CHT', 'zh-HK': 'zh-CHT'}
@ -28,71 +29,80 @@ language_aliases = {'zh-CN': 'zh-CHS', 'zh-TW': 'zh-CHT', 'zh-HK': 'zh-CHT'}
base_url = 'https://www.bing.com/' base_url = 'https://www.bing.com/'
search_string = 'search?{query}&first={offset}' search_string = 'search?{query}&first={offset}'
def _get_offset_from_pageno(pageno): def _get_offset_from_pageno(pageno):
return (pageno - 1) * 10 + 1 return (pageno - 1) * 10 + 1
# do search-request
def request(query, params): def request(query, params):
offset = _get_offset_from_pageno(params.get('pageno', 0))
offset = _get_offset_from_pageno(params.get('pageno', 0))
if params['language'] == 'all': if params['language'] == 'all':
lang = 'EN' lang = 'EN'
else: else:
lang = match_language(params['language'], supported_languages, language_aliases) lang = match_language(
params['language'], supported_languages, language_aliases
)
query = 'language:{} {}'.format(lang.split('-')[0].upper(), query) query = 'language:{} {}'.format(
lang.split('-')[0].upper(), query
)
search_path = search_string.format( search_path = search_string.format(
query=urlencode({'q': query}), query = urlencode({'q': query}),
offset=offset) offset = offset)
params['url'] = base_url + search_path params['url'] = base_url + search_path
return params return params
# get response from search-request
def response(resp): def response(resp):
results = [] results = []
result_len = 0 result_len = 0
dom = html.fromstring(resp.text) dom = html.fromstring(resp.text)
# parse results
for result in eval_xpath(dom, '//div[@class="sa_cc"]'): for result in eval_xpath(dom, '//div[@class="sa_cc"]'):
link = eval_xpath(result, './/h3/a')[0] link = eval_xpath(result, './/h3/a')[0]
url = link.attrib.get('href') url = link.attrib.get('href')
title = extract_text(link) title = extract_text(link)
content = extract_text(eval_xpath(result, './/p')) content = extract_text(eval_xpath(result, './/p'))
# append result # append result
results.append({'url': url, results.append({
'title': title, 'url': url,
'content': content}) 'title': title,
'content': content
})
# parse results again if nothing is found yet # parse results again if nothing is found yet
for result in eval_xpath(dom, '//li[@class="b_algo"]'): for result in eval_xpath(dom, '//li[@class="b_algo"]'):
link = eval_xpath(result, './/h2/a')[0] link = eval_xpath(result, './/h2/a')[0]
url = link.attrib.get('href') url = link.attrib.get('href')
title = extract_text(link) title = extract_text(link)
content = extract_text(eval_xpath(result, './/p')) content = extract_text(eval_xpath(result, './/p'))
# append result # append result
results.append({'url': url, results.append({
'title': title, 'url': url,
'content': content}) 'title': title,
'content': content
})
try: try:
result_len_container = "".join(eval_xpath(dom, '//span[@class="sb_count"]//text()')) result_len_container = "".join(eval_xpath(dom, '//span[@class="sb_count"]//text()'))
if "-" in result_len_container: if "-" in result_len_container:
# Remove the part "from-to" for paginated request ... # Remove the part "from-to" for paginated request ...
result_len_container = result_len_container[result_len_container.find("-") * 2 + 2:] result_len_container = result_len_container[result_len_container.find("-") * 2 + 2:]
result_len_container = re.sub('[^0-9]', '', result_len_container) result_len_container = re.sub('[^0-9]', '', result_len_container)
if len(result_len_container) > 0: if len(result_len_container) > 0:
result_len = int(result_len_container) result_len = int(result_len_container)
except Exception as e:
except Exception as e: # pylint: disable=broad-except
logger.debug('result error :\n%s', e) logger.debug('result error :\n%s', e)
if result_len and _get_offset_from_pageno(resp.search_params.get("pageno", 0)) > result_len: if result_len and _get_offset_from_pageno(resp.search_params.get("pageno", 0)) > result_len: