Commit graph

33 commits

Author SHA1 Message Date
Chris McCord
924da28b6b Move presence tracking to player 2022-01-12 12:27:30 -05:00
Berenice Medel
216916817b configure presence for tracking the users listening a playlist 2022-01-11 14:04:27 -05:00
Chris McCord
a0f3b76f61
Merge pull request #18 from ndarilek/hide-empty-metadata
Hide title/artist metadata when empty.
2022-01-10 14:56:32 -05:00
Chris McCord
c5b25aa5be Add standalone tailwind 2022-01-07 13:42:04 -05:00
Nolan Darilek
7fdb30520e Hide title/artist metadata when empty.
From an accessibility perspective, having an empty `<h2/>` is confusing. Even though it lacks text, it remains visible to scree readers and is still navigable.

I'm not sure whether wrapping the entire `<div/>` in this check breaks the layout, or if the individual elements should have `aria-hidden` set if their values are empty.
2021-12-14 12:17:40 -06:00
Chris McCord
c8a6035a02 Fixup tests 2021-12-14 10:35:51 -05:00
Berenice Medel
e5c663ab38 show stop button when listening someone else playlist 2021-11-29 19:23:23 -06:00
Chris McCord
a325b385b3 Rename link attrs 2021-11-23 09:34:46 -05:00
Nolan Darilek
ef1355f897 Set aria-hidden="true" on more SVG graphics, and hide icons by default.
The original icon fix assumed that the `<svg>` tag had an `alt` attribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, set `aria-hidden="true"` by default and require it to be overridden if needed.
2021-11-22 13:50:20 -06:00
Nolan Darilek
5cf58b2b77 Minor cleanup to make navigating by region easier.
* Make `<main>` the part of the page that actually changes when the route updates, thus making navigation to page content easier.
* Add labelled region for persistent audio player.
2021-11-22 13:18:06 -06:00
Chris McCord
198846433b Resolve conflicts 2021-11-22 10:37:56 -05:00
Nolan Darilek
72501c90b4 Remove aria-hidden on icons in favor of empty alt text.
This matches better with adding alt text to images, which is probably better than either manually opting out of the accessibility tree or creating some less-compatible implementation.
2021-11-17 09:30:33 -06:00
Chris McCord
44a36a8763 Fix icon alignment 2021-11-16 22:26:33 -05:00
Nolan Darilek
fad37064db Label player controls. 2021-11-16 14:26:10 -06:00
Nolan Darilek
f7db67f636 Hide icons with associated buttons from accessibility tree. 2021-11-16 14:14:17 -06:00
Chris McCord
e873619a66 Add event dispatch system with more profile updates 2021-11-12 12:41:16 -05:00
Chris McCord
5ca7357665 Show active users in sidebar 2021-11-12 10:10:04 -05:00
Chris McCord
b3fe0ab666 Use event structs 2021-11-12 06:42:07 -05:00
Chris McCord
ed8ad74141 Only render delete song button if owner 2021-11-12 06:21:12 -05:00
Chris McCord
c45510cb6e Add profiles 2021-11-11 22:42:10 -05:00
Chris McCord
ec900a1703 Add next/prev 2021-11-10 14:49:38 -05:00
Chris McCord
7708779b9f Auto advance to next song via client 2021-11-10 14:29:53 -05:00
Chris McCord
635a2c9d21 Make sidebar live and add enhanced flash 2021-11-10 13:23:02 -05:00
Chris McCord
eda99fa903 Add attribution field and handle async duration race 2021-11-10 10:10:43 -05:00
Chris McCord
17db535839 Move audio enabling entirely to client 2021-11-08 14:32:40 -05:00
Chris McCord
5f593dfaf2 Lock files behind temporary token 2021-11-05 23:02:31 -04:00
Chris McCord
287f78ab2a Synced playing fixup 2021-11-05 15:57:33 -04:00
Chris McCord
60382feddc Initial synced playback 2021-11-04 20:49:19 -04:00
Chris McCord
da7a54a1c3 Uploads WIP 2021-10-31 21:19:52 -04:00
Chris McCord
2552a32865 UI function components 2021-10-29 12:12:23 -04:00
Chris McCord
708bf715e1 WIP 2021-10-27 16:02:56 -04:00
Chris McCord
e28abc0a0a Add github login 2021-09-08 10:58:32 -04:00
Chris McCord
f9edbf76ba Fixed media player 2021-09-03 09:57:15 -04:00