mirrors/live_beats
1
0
Fork 0
mirror of https://github.com/fly-apps/live_beats.git synced 2024-11-22 16:10:59 +00:00
Code Issues Projects Releases Wiki Activity
257 commits 9 branches 0 tags 1 MiB
Commit graph

257 commits

This branch
This branch
All branches
Author SHA1 Message Date
Berenice Medel
9262895d13 fix typo 2021-11-30 09:03:08 -06:00
Berenice Medel
e5c663ab38 show stop button when listening someone else playlist 2021-11-29 19:23:23 -06:00
Berenice Medel
0e0d349e31 hide play button on playlist 2021-11-29 19:21:35 -06:00
Chris McCord
5e3149ad8e Only active tab user's own profile 2021-11-23 22:06:48 -05:00
Nolan Darilek
ca311dd11d Further sidebar accessibility improvements. 
* Set `aria-controls` to the sidebar container.
* Swap button focus as sidebar is revealed/hidden.
 2021-11-23 11:41:07 -06:00
Nolan Darilek
ad13a8c364 Partial implementation of ARIA disclosure pattern for sidebar. 
* Hide/show buttons to reveal sidebar as appropriate.
* Hard-code `aria-expanded`, since by default only one button is exposed at a given time.
 2021-11-23 11:29:49 -06:00
Chris McCord
a325b385b3 Rename link attrs 2021-11-23 09:34:46 -05:00
Chris McCord
7f9b7c5f9a Assign active_tab in handle_params to handle live patches 2021-11-23 09:34:46 -05:00
Nolan Darilek
566a574c0a Initial attempt at accessibly announcing route updates. 
* Add handler for `phx:page-loading-stop` that focuses either the first `<h1>` child of `<main>`, or `<main>` directly if no child `<h1>` is present. Make this our focus target.
* Cache original `tabindex` of target, if any, and assign it a temporary `tabindex1 of -1.
* Focus the target.
* After a long timeout, either restore the target's original `tabindex` or remove the temporary -1 value. Short timeouts didn't seem to perform the focus step. Neither did nested `requestAnimationFrame` calls.
 2021-11-22 15:25:41 -06:00
Nolan Darilek
7096b98cc2 Add alert role on connection status so it is read automatically on change. 
Note: not currently tested since I'm not sure how to force these states, but I did notice them happening from time to time so wanted to try addressing them..
 2021-11-22 15:24:10 -06:00
Nolan Darilek
6d95137d1f Set aria-current on active tab to indicate to screen readers which is selected. 2021-11-22 14:20:10 -06:00
Chris McCord
62e00dc447
Merge pull request #13 from ndarilek/graphics-cleanup 
Set `aria-hidden="true"` on more SVG graphics, and hide icons by default.
 2021-11-22 14:55:17 -05:00
Nolan Darilek
ef1355f897 Set aria-hidden="true" on more SVG graphics, and hide icons by default. 
The original icon fix assumed that the `<svg>` tag had an `alt` attribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, set `aria-hidden="true"` by default and require it to be overridden if needed.
 2021-11-22 13:50:20 -06:00
Chris McCord
982e626424
Merge pull request #10 from ndarilek/dropdown-a11y 
When a dropdown is open, block Tab to avoid navigating away.
 2021-11-22 14:29:04 -05:00
Chris McCord
cead091227
Update assets/js/app.js 2021-11-22 14:28:57 -05:00
Chris McCord
a0e64ef901
Merge pull request #12 from ndarilek/cleaner-regions 
Minor cleanup to make navigating by region easier.
 2021-11-22 14:28:07 -05:00
Nolan Darilek
5cf58b2b77 Minor cleanup to make navigating by region easier. 
* Make `<main>` the part of the page that actually changes when the route updates, thus making navigation to page content easier.
* Add labelled region for persistent audio player.
 2021-11-22 13:18:06 -06:00
Nolan Darilek
a19a6091e6 When a dropdown is open, block Tab to avoid navigating away. 
Under Windows, dropdowns cannot be tabbed off of. They are only closed by either selecting an item or pressing Escape.
 2021-11-22 12:55:01 -06:00
Chris McCord
d35554ee0e Link logo placeholder 2021-11-22 13:04:05 -05:00
Chris McCord
55a1e1f02a Logo placeholder 2021-11-22 12:50:42 -05:00
Chris McCord
7209a3121c Add dropdown component 2021-11-22 11:21:11 -05:00
Chris McCord
81b86c2c21
Merge pull request #2 from ndarilek/ndarilek-onboarding 
Link directly to app creation page in README.
 2021-11-22 10:40:27 -05:00
Chris McCord
b46277c78b Merge branch 'ndarilek-accessibility-round-1' 2021-11-22 10:38:27 -05:00
Chris McCord
198846433b Resolve conflicts 2021-11-22 10:37:56 -05:00
Chris McCord
aec76630d1 Remove unnecessary attr 2021-11-22 10:36:18 -05:00
Chris McCord
a7c319c035 Use live_action instead of params 2021-11-22 10:31:40 -05:00
Chris McCord
632b211c44
Merge pull request #7 from chrismccord/fix/avoid_raise_error_on_duplicated_song 
Handle unique song title constraint error on upload
 2021-11-22 09:58:02 -05:00
Chris McCord
bb23d8e071 Rename SongLive modules to ProfileLive 2021-11-22 09:57:24 -05:00
Chris McCord
8b5c77ca90 Tweak highlight hover styles 2021-11-22 09:44:56 -05:00
Chris McCord
8ee6b39ad5 Show connection status flash 2021-11-22 09:24:41 -05:00
Chris McCord
6849e108d7
Merge pull request #8 from chrismccord/feature/set_active_tab_in_navbar 
Active tab highlighted in sidebar based on current URL
 2021-11-22 09:23:40 -05:00
Berenice Medel
1a1bbe295e show active tab in navbar 2021-11-19 13:50:36 -06:00
Berenice Medel
11d5cd8cdd add unique constraint on songs changeset 2021-11-19 13:01:15 -06:00
Chris McCord
023ddc2806 Rename songs_number to songs_count and refactor error messages 2021-11-19 10:51:50 -05:00
Chris McCord
19241308ae
Merge pull request #5 from chrismccord/feature/validate_max_songs_per_account 
Limit # of songs per account
 2021-11-19 10:22:28 -05:00
Chris McCord
07d1dbf744 Fixup flash hiding 2021-11-19 09:55:26 -05:00
Chris McCord
6622f791e0 Use keydown event to detect keyboard based clicks 
Relying on e.detail is not supported on all OS/browsers
 2021-11-18 22:09:01 -05:00
Berenice Medel
43bb03fb42 decrement songs_number with multi.update_all 2021-11-18 15:50:05 -06:00
Berenice Medel
64969fca31 handle raise conditions in multiple uploads 2021-11-18 15:36:51 -06:00
Chris McCord
7d8e1f2ec6 Reset focus on escape 2021-11-18 16:17:47 -05:00
Chris McCord
a643ca9fe5 Wrap focus 2021-11-18 16:01:29 -05:00
Chris McCord
41505c00cb Bump LV 2021-11-18 15:31:15 -05:00
Chris McCord
f52eeb22c3 aria popup 2021-11-18 15:22:22 -05:00
Chris McCord
1dc43ac366 Fix focus and keyboard nav 
Only enable keyboard nav and focus if button is
triggered by keyboard event
 2021-11-18 15:21:07 -05:00
Chris McCord
d1f57d7514 Fix bad url recovery 2021-11-18 11:50:15 -05:00
Chris McCord
0ef460675c Increase connections 2021-11-18 10:40:05 -05:00
Chris McCord
30b46e95e5 Add aria menu hook and use in sidebar 2021-11-18 09:55:09 -05:00
Berenice Medel
984c1c8523 decrement songs_number when a song is deleted 2021-11-17 15:32:09 -06:00
Berenice Medel
74c720180e validate max songs per account in upload form 2021-11-17 15:31:34 -06:00
Chris McCord
809a8de665 Use LV master 2021-11-17 13:15:30 -05:00