mirrors/live_beats
1
0
Fork 0
mirror of https://github.com/fly-apps/live_beats.git synced 2024-11-22 16:10:59 +00:00
Code Issues Projects Releases Wiki Activity
225 commits 9 branches 0 tags 1 MiB
Commit graph

117 commits

Author SHA1 Message Date
Nolan Darilek
7fdb30520e Hide title/artist metadata when empty. 
From an accessibility perspective, having an empty `<h2/>` is confusing. Even though it lacks text, it remains visible to scree readers and is still navigable.

I'm not sure whether wrapping the entire `<div/>` in this check breaks the layout, or if the individual elements should have `aria-hidden` set if their values are empty.
 2021-12-14 12:17:40 -06:00
Chris McCord
c8a6035a02 Fixup tests 2021-12-14 10:35:51 -05:00
Chris McCord
57c193e490
Merge pull request #14 from ndarilek/accessible-routing 
Initial work on making routing more accessible
 2021-12-13 13:21:04 -05:00
Chris McCord
7db38a70ab
Merge pull request #15 from ndarilek/sidebar-a11y 
Improve accessibility of mobile sidebar
 2021-12-13 13:19:53 -05:00
Berenice Medel
9262895d13 fix typo 2021-11-30 09:03:08 -06:00
Berenice Medel
e5c663ab38 show stop button when listening someone else playlist 2021-11-29 19:23:23 -06:00
Berenice Medel
0e0d349e31 hide play button on playlist 2021-11-29 19:21:35 -06:00
Chris McCord
5e3149ad8e Only active tab user's own profile 2021-11-23 22:06:48 -05:00
Nolan Darilek
ca311dd11d Further sidebar accessibility improvements. 
* Set `aria-controls` to the sidebar container.
* Swap button focus as sidebar is revealed/hidden.
 2021-11-23 11:41:07 -06:00
Nolan Darilek
ad13a8c364 Partial implementation of ARIA disclosure pattern for sidebar. 
* Hide/show buttons to reveal sidebar as appropriate.
* Hard-code `aria-expanded`, since by default only one button is exposed at a given time.
 2021-11-23 11:29:49 -06:00
Chris McCord
a325b385b3 Rename link attrs 2021-11-23 09:34:46 -05:00
Chris McCord
7f9b7c5f9a Assign active_tab in handle_params to handle live patches 2021-11-23 09:34:46 -05:00
Nolan Darilek
7096b98cc2 Add alert role on connection status so it is read automatically on change. 
Note: not currently tested since I'm not sure how to force these states, but I did notice them happening from time to time so wanted to try addressing them..
 2021-11-22 15:24:10 -06:00
Nolan Darilek
ef1355f897 Set aria-hidden="true" on more SVG graphics, and hide icons by default. 
The original icon fix assumed that the `<svg>` tag had an `alt` attribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, set `aria-hidden="true"` by default and require it to be overridden if needed.
 2021-11-22 13:50:20 -06:00
Nolan Darilek
5cf58b2b77 Minor cleanup to make navigating by region easier. 
* Make `<main>` the part of the page that actually changes when the route updates, thus making navigation to page content easier.
* Add labelled region for persistent audio player.
 2021-11-22 13:18:06 -06:00
Chris McCord
d35554ee0e Link logo placeholder 2021-11-22 13:04:05 -05:00
Chris McCord
7209a3121c Add dropdown component 2021-11-22 11:21:11 -05:00
Chris McCord
198846433b Resolve conflicts 2021-11-22 10:37:56 -05:00
Chris McCord
aec76630d1 Remove unnecessary attr 2021-11-22 10:36:18 -05:00
Chris McCord
a7c319c035 Use live_action instead of params 2021-11-22 10:31:40 -05:00
Chris McCord
bb23d8e071 Rename SongLive modules to ProfileLive 2021-11-22 09:57:24 -05:00
Chris McCord
8ee6b39ad5 Show connection status flash 2021-11-22 09:24:41 -05:00
Berenice Medel
1a1bbe295e show active tab in navbar 2021-11-19 13:50:36 -06:00
Chris McCord
023ddc2806 Rename songs_number to songs_count and refactor error messages 2021-11-19 10:51:50 -05:00
Chris McCord
19241308ae
Merge pull request #5 from chrismccord/feature/validate_max_songs_per_account 
Limit # of songs per account
 2021-11-19 10:22:28 -05:00
Chris McCord
07d1dbf744 Fixup flash hiding 2021-11-19 09:55:26 -05:00
Berenice Medel
64969fca31 handle raise conditions in multiple uploads 2021-11-18 15:36:51 -06:00
Chris McCord
d1f57d7514 Fix bad url recovery 2021-11-18 11:50:15 -05:00
Chris McCord
30b46e95e5 Add aria menu hook and use in sidebar 2021-11-18 09:55:09 -05:00
Berenice Medel
74c720180e validate max songs per account in upload form 2021-11-17 15:31:34 -06:00
Nolan Darilek
72501c90b4 Remove aria-hidden on icons in favor of empty alt text. 
This matches better with adding alt text to images, which is probably better than either manually opting out of the accessibility tree or creating some less-compatible implementation.
 2021-11-17 09:30:33 -06:00
Chris McCord
44a36a8763 Fix icon alignment 2021-11-16 22:26:33 -05:00
Chris McCord
2f4940fab6 Fixup profiles 2021-11-16 15:54:40 -05:00
Nolan Darilek
fad37064db Label player controls. 2021-11-16 14:26:10 -06:00
Nolan Darilek
f7db67f636 Hide icons with associated buttons from accessibility tree. 2021-11-16 14:14:17 -06:00
Chris McCord
364b0659e1 Deploy and presence stub 2021-11-16 11:58:28 -05:00
Chris McCord
e496ff0a4e Docs 2021-11-15 13:06:04 -05:00
Chris McCord
e873619a66 Add event dispatch system with more profile updates 2021-11-12 12:41:16 -05:00
Chris McCord
5ca7357665 Show active users in sidebar 2021-11-12 10:10:04 -05:00
Chris McCord
b3fe0ab666 Use event structs 2021-11-12 06:42:07 -05:00
Chris McCord
ed8ad74141 Only render delete song button if owner 2021-11-12 06:21:12 -05:00
Chris McCord
c45510cb6e Add profiles 2021-11-11 22:42:10 -05:00
Chris McCord
5fa2944627 Remove inspect 2021-11-10 21:58:28 -05:00
Chris McCord
7c6ee5dc1a Fix dup handler 2021-11-10 21:53:39 -05:00
Chris McCord
d9b5a61702 Limit number of error messages 2021-11-10 15:07:46 -05:00
Chris McCord
0f384a3cb8 Kill sleep 2021-11-10 15:04:15 -05:00
Chris McCord
ec900a1703 Add next/prev 2021-11-10 14:49:38 -05:00
Chris McCord
7708779b9f Auto advance to next song via client 2021-11-10 14:29:53 -05:00
Chris McCord
635a2c9d21 Make sidebar live and add enhanced flash 2021-11-10 13:23:02 -05:00
Chris McCord
f482d5143a Update flash 2021-11-10 11:56:01 -05:00
Chris McCord
eda99fa903 Add attribution field and handle async duration race 2021-11-10 10:10:43 -05:00
Chris McCord
ff7b064660 settings 2021-11-09 06:20:10 -05:00
Chris McCord
17db535839 Move audio enabling entirely to client 2021-11-08 14:32:40 -05:00
Chris McCord
6358b0bb3b Fix changeset handling by recycling 2021-11-08 13:46:23 -05:00
Chris McCord
5f593dfaf2 Lock files behind temporary token 2021-11-05 23:02:31 -04:00
Chris McCord
287f78ab2a Synced playing fixup 2021-11-05 15:57:33 -04:00
Chris McCord
3ff4ae2bea Drop invalid uploads as they happen 2021-11-05 08:57:48 -04:00
Chris McCord
d7ccc9282c Add hero icons with icon component 2021-11-04 21:20:31 -04:00
Chris McCord
60382feddc Initial synced playback 2021-11-04 20:49:19 -04:00
Chris McCord
aaa89c7c76 Checkpoint 2021-11-02 12:24:53 -04:00
Chris McCord
1d37ec3c5c Checkpoint 2021-11-01 23:25:28 -04:00
Chris McCord
50ecdb8ced Initial file uploads with copying 2021-11-01 15:57:53 -04:00
Chris McCord
da7a54a1c3 Uploads WIP 2021-10-31 21:19:52 -04:00
Chris McCord
2552a32865 UI function components 2021-10-29 12:12:23 -04:00
Chris McCord
708bf715e1 WIP 2021-10-27 16:02:56 -04:00
Chris McCord
e28abc0a0a Add github login 2021-09-08 10:58:32 -04:00
Chris McCord
f9edbf76ba Fixed media player 2021-09-03 09:57:15 -04:00