Berenice Medel
216916817b
configure presence for tracking the users listening a playlist
2022-01-11 14:04:27 -05:00
Chris McCord
a0f3b76f61
Merge pull request #18 from ndarilek/hide-empty-metadata
...
Hide title/artist metadata when empty.
2022-01-10 14:56:32 -05:00
Chris McCord
ad3cab4d29
Merge pull request #20 from ndarilek/playlist-a11y
...
Improve playlist accessibility
2022-01-07 15:24:00 -05:00
Chris McCord
cb781d855e
Merge branch 'cm-tailwind-standalone'
2022-01-07 13:42:26 -05:00
Chris McCord
fba89209bd
Merge branch 'master' of github.com:chrismccord/live_beats
2022-01-07 13:42:12 -05:00
Chris McCord
c5b25aa5be
Add standalone tailwind
2022-01-07 13:42:04 -05:00
Nolan Darilek
57150a4f7a
Add additional region for search region when mobile sidebar is displayed.
2021-12-20 12:13:49 -06:00
Nolan Darilek
159363fb4b
Add button role to icons to hint that they are actionable.
2021-12-20 11:02:36 -06:00
Nolan Darilek
3860c79ec7
If an icon has aria-labelset, don't set aria-hidden. Also, label some icons.
2021-12-16 15:26:12 -06:00
Chris McCord
bbb9693e8c
WIP
2021-12-16 11:06:22 -05:00
Chris McCord
67a291ac3a
Revert temporary assign
2021-12-15 22:03:18 -05:00
Chris McCord
8da032fed3
Make songs temporary assigns
2021-12-15 21:51:09 -05:00
Chris McCord
ce1a1fdc5f
Do not focus outline h1 in title bar
2021-12-15 12:48:05 -05:00
Chris McCord
803f0b52cc
Test bad inputs
2021-12-14 21:07:02 -05:00
Chris McCord
816eb78064
Add mp3stat test
2021-12-14 21:02:50 -05:00
Chris McCord
570e86d02c
Test song deletion
2021-12-14 15:29:07 -05:00
Chris McCord
dda0cdaa3f
Test basic uploads
2021-12-14 15:19:03 -05:00
Nolan Darilek
7fdb30520e
Hide title/artist metadata when empty.
...
From an accessibility perspective, having an empty `<h2/>` is confusing. Even though it lacks text, it remains visible to scree readers and is still navigable.
I'm not sure whether wrapping the entire `<div/>` in this check breaks the layout, or if the individual elements should have `aria-hidden` set if their values are empty.
2021-12-14 12:17:40 -06:00
Chris McCord
c8a6035a02
Fixup tests
2021-12-14 10:35:51 -05:00
Chris McCord
57c193e490
Merge pull request #14 from ndarilek/accessible-routing
...
Initial work on making routing more accessible
2021-12-13 13:21:04 -05:00
Chris McCord
7db38a70ab
Merge pull request #15 from ndarilek/sidebar-a11y
...
Improve accessibility of mobile sidebar
2021-12-13 13:19:53 -05:00
Berenice Medel
9262895d13
fix typo
2021-11-30 09:03:08 -06:00
Berenice Medel
e5c663ab38
show stop button when listening someone else playlist
2021-11-29 19:23:23 -06:00
Berenice Medel
0e0d349e31
hide play button on playlist
2021-11-29 19:21:35 -06:00
Chris McCord
5e3149ad8e
Only active tab user's own profile
2021-11-23 22:06:48 -05:00
Nolan Darilek
ca311dd11d
Further sidebar accessibility improvements.
...
* Set `aria-controls` to the sidebar container.
* Swap button focus as sidebar is revealed/hidden.
2021-11-23 11:41:07 -06:00
Nolan Darilek
ad13a8c364
Partial implementation of ARIA disclosure pattern for sidebar.
...
* Hide/show buttons to reveal sidebar as appropriate.
* Hard-code `aria-expanded`, since by default only one button is exposed at a given time.
2021-11-23 11:29:49 -06:00
Chris McCord
a325b385b3
Rename link attrs
2021-11-23 09:34:46 -05:00
Chris McCord
7f9b7c5f9a
Assign active_tab in handle_params to handle live patches
2021-11-23 09:34:46 -05:00
Nolan Darilek
7096b98cc2
Add alert role on connection status so it is read automatically on change.
...
Note: not currently tested since I'm not sure how to force these states, but I did notice them happening from time to time so wanted to try addressing them..
2021-11-22 15:24:10 -06:00
Nolan Darilek
6d95137d1f
Set aria-current on active tab to indicate to screen readers which is selected.
2021-11-22 14:20:10 -06:00
Nolan Darilek
ef1355f897
Set aria-hidden="true" on more SVG graphics, and hide icons by default.
...
The original icon fix assumed that the `<svg>` tag had an `alt` attribute, which it does not. Instead, SVG requires a child element to specify a description. A complete fix involves patching upstream to allow for setting this element, but since we don't seem to have actionable icons without associated textual controls, set `aria-hidden="true"` by default and require it to be overridden if needed.
2021-11-22 13:50:20 -06:00
Nolan Darilek
5cf58b2b77
Minor cleanup to make navigating by region easier.
...
* Make `<main>` the part of the page that actually changes when the route updates, thus making navigation to page content easier.
* Add labelled region for persistent audio player.
2021-11-22 13:18:06 -06:00
Chris McCord
d35554ee0e
Link logo placeholder
2021-11-22 13:04:05 -05:00
Chris McCord
55a1e1f02a
Logo placeholder
2021-11-22 12:50:42 -05:00
Chris McCord
7209a3121c
Add dropdown component
2021-11-22 11:21:11 -05:00
Chris McCord
198846433b
Resolve conflicts
2021-11-22 10:37:56 -05:00
Chris McCord
aec76630d1
Remove unnecessary attr
2021-11-22 10:36:18 -05:00
Chris McCord
a7c319c035
Use live_action instead of params
2021-11-22 10:31:40 -05:00
Chris McCord
632b211c44
Merge pull request #7 from chrismccord/fix/avoid_raise_error_on_duplicated_song
...
Handle unique song title constraint error on upload
2021-11-22 09:58:02 -05:00
Chris McCord
bb23d8e071
Rename SongLive modules to ProfileLive
2021-11-22 09:57:24 -05:00
Chris McCord
8b5c77ca90
Tweak highlight hover styles
2021-11-22 09:44:56 -05:00
Chris McCord
8ee6b39ad5
Show connection status flash
2021-11-22 09:24:41 -05:00
Berenice Medel
1a1bbe295e
show active tab in navbar
2021-11-19 13:50:36 -06:00
Berenice Medel
11d5cd8cdd
add unique constraint on songs changeset
2021-11-19 13:01:15 -06:00
Chris McCord
023ddc2806
Rename songs_number to songs_count and refactor error messages
2021-11-19 10:51:50 -05:00
Chris McCord
19241308ae
Merge pull request #5 from chrismccord/feature/validate_max_songs_per_account
...
Limit # of songs per account
2021-11-19 10:22:28 -05:00
Chris McCord
07d1dbf744
Fixup flash hiding
2021-11-19 09:55:26 -05:00
Berenice Medel
43bb03fb42
decrement songs_number with multi.update_all
2021-11-18 15:50:05 -06:00
Berenice Medel
64969fca31
handle raise conditions in multiple uploads
2021-11-18 15:36:51 -06:00
