mirrors/live_beats
1
0
Fork 0
mirror of https://github.com/fly-apps/live_beats.git synced 2024-11-14 20:21:01 +00:00
Code Issues Projects Releases Wiki Activity

Further simplify post-route handler.

Browse source 
* Use `HtmlElement.tabIndex` directly rather than going through attributes.
* Always restore `tabIndex` after focus.
* Remove `setTimeout` to simplify implementation.

This does have a disadvantage in that it leaves unnecessary `tabindex="1"` instances around. On the other hand, it does simplify the implementation and get the job done' so is probably a more clear example of how to do this correctly.
This commit is contained in:
Nolan Darilek 2021-12-22 12:41:19 -06:00
parent 7d09845b8c
commit 7b48c2fbaf
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
assets/js/app.js
View file

@ -180,16 +180,10 @@ let liveSocket = new LiveSocket("/live", Socket, {
let routeUpdated = () => {
let target = document.querySelector("main h1") || document.querySelector("main")
if (target) {
let origTabIndex = target.getAttribute("tabindex")
target.setAttribute("tabindex", "-1")
let origTabIndex = target.tabIndex
target.tabIndex = -1
target.focus()
window.setTimeout(() => {
if (origTabIndex) {
target.setAttribute("tabindex", origTabIndex)
} else {
target.removeAttribute("tabindex")
}
}, 1000)
target.tabIndex = origTabIndex
}
}