gstreamer/ext
Enrique Ocaña González 34ef2b2759 glcolorbalance: Error out on unsupported texture target types
The issue can be reproduced on a computer with a Radeon graphics card
when trying to force GStreamer Editing Services to use GL for video
mixing in GESSmartMixer, instead of the GstCompositor that smart mixer
would normally use. This change causes the resulting video stream to
have "video/x-raw(memory:GLMemory) ... texture-target: 2D" caps (instead
of "video/x-raw ..." caps). At the PlaySink stage of the pipeline, a
GstGLImageSinkBin is plugged, with a GstGLColorBalance on it. For some
reason that is still to be debugged (and out of the scope of this
patch), gst_gl_filter_set_caps() is never called on that color balance
element, leaving filter->in_texture_target set to its default
GST_GL_TEXTURE_TARGET_NONE value. The incomplete _create_shader() logic
does the rest and silently generates a shader code that doesn't build.

This is the command I use to reproduce the issue (I'm not sure if I
would be able to isolate the issue in a simple pipeline, though):

 GST_PLUGIN_FEATURE_RANK=vaapih265enc:NONE,vaapih264enc:NONE,vaapisink:NONE,vaapidecodebin:NONE,vaapipostproc:NONE,vaapih265dec:NONE,vaapivc1dec:NONE,vaapih264dec:NONE,vaapimpeg2dec:NONE,vaapijpegdec:NONE,glvideomixer:260
 ges-launch-1.0 +clip /tmp/video.mp4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1159>
2021-05-20 13:22:24 +00:00
..
alsa audio/alsa: Exit write loop if underlying device is already paused. 2021-04-08 07:28:21 +00:00
cdparanoia cdparanoiasrc: allow per feature registration 2021-03-16 17:58:59 +00:00
gl glcolorbalance: Error out on unsupported texture target types 2021-05-20 13:22:24 +00:00
libvisual libvisual: workaround clang warning 2020-12-14 11:37:56 +00:00
ogg ogg: element_init returns void 2021-03-16 17:59:00 +00:00
opus opusdec: Add Converter class to hint gst-validate 2021-05-11 15:06:39 -04:00
pango basetextoverlay: add debug category 2021-05-17 10:20:05 +00:00
theora theora: allow per feature registration 2021-03-16 17:58:59 +00:00
vorbis vorbis: avoid duplicate symbols 2021-04-21 12:40:53 +02:00
meson.build meson: Remove outdated msvc-specific disabling code 2019-02-21 19:19:09 +05:30