mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-09-09 05:38:58 +00:00
f5c7ada98e
The current way of GstVaDecodePicture's finalize will leak some resource such as parameter buffers and slice data. The current way deliberately leaves these resource releasing logic to va decoder related function and trigger a warning if we free the GstVaDecodePicture without releasing these resources. But in practice, sometimes, you do not have the chance to release these resource before picture is freed. For example, H264/Mpeg2 support multi slice NALs/Packets for one frame. It is possible that we already succeed to parse and generate the first several slices data by _decode_slice(), but then we get a wrong slice NAL/packet and fail to parse it. We decide to discard the whole frame in the decoder's base class, it just free the current picture and does not trigger sub class's function again. In this kind of cases, we do not have the chance to cleanup the resource, and the resource will be leaked. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1841>
85 lines
4.5 KiB
C
85 lines
4.5 KiB
C
/* GStreamer
|
|
* Copyright (C) 2020 Igalia, S.L.
|
|
* Author: Víctor Jáquez <vjaquez@igalia.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "gstvadisplay.h"
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
typedef struct _GstVaDecodePicture GstVaDecodePicture;
|
|
struct _GstVaDecodePicture
|
|
{
|
|
VADisplay display;
|
|
GArray *buffers;
|
|
GArray *slices;
|
|
GstBuffer *gstbuffer;
|
|
};
|
|
|
|
#define GST_TYPE_VA_DECODER (gst_va_decoder_get_type())
|
|
G_DECLARE_FINAL_TYPE (GstVaDecoder, gst_va_decoder, GST, VA_DECODER, GstObject)
|
|
|
|
GstVaDecoder * gst_va_decoder_new (GstVaDisplay * display,
|
|
guint32 codec);
|
|
gboolean gst_va_decoder_open (GstVaDecoder * self,
|
|
VAProfile profile,
|
|
guint rt_format);
|
|
gboolean gst_va_decoder_close (GstVaDecoder * self);
|
|
gboolean gst_va_decoder_is_open (GstVaDecoder * self);
|
|
gboolean gst_va_decoder_set_format (GstVaDecoder * self,
|
|
gint coded_width,
|
|
gint coded_height,
|
|
GArray * surfaces);
|
|
GstCaps * gst_va_decoder_get_srcpad_caps (GstVaDecoder * self);
|
|
GstCaps * gst_va_decoder_get_sinkpad_caps (GstVaDecoder * self);
|
|
gboolean gst_va_decoder_has_profile (GstVaDecoder * self,
|
|
VAProfile profile);
|
|
gint gst_va_decoder_get_mem_types (GstVaDecoder * self);
|
|
GArray * gst_va_decoder_get_surface_formats (GstVaDecoder * self);
|
|
|
|
gboolean gst_va_decoder_add_param_buffer (GstVaDecoder * self,
|
|
GstVaDecodePicture * pic,
|
|
gint type,
|
|
gpointer data,
|
|
gsize size);
|
|
gboolean gst_va_decoder_add_slice_buffer (GstVaDecoder * self,
|
|
GstVaDecodePicture * pic,
|
|
gpointer params_data,
|
|
gsize params_size,
|
|
gpointer slice_data,
|
|
gsize slice_size);
|
|
gboolean gst_va_decoder_decode (GstVaDecoder * self,
|
|
GstVaDecodePicture * pic);
|
|
gboolean gst_va_decoder_destroy_buffers (GstVaDecoder * self,
|
|
GstVaDecodePicture * pic);
|
|
|
|
GstVaDecodePicture * gst_va_decode_picture_new (GstVaDecoder * self,
|
|
GstBuffer * buffer);
|
|
VASurfaceID gst_va_decode_picture_get_surface (GstVaDecodePicture * pic);
|
|
void gst_va_decode_picture_free (GstVaDecodePicture * pic);
|
|
GstVaDecodePicture * gst_va_decode_picture_dup (GstVaDecodePicture * pic);
|
|
|
|
gboolean gst_va_decoder_format_changed (GstVaDecoder * decoder,
|
|
VAProfile new_profile,
|
|
guint new_rtformat,
|
|
gint new_width,
|
|
gint new_height);
|
|
|
|
G_END_DECLS
|