Bastien Nocera e37c462f87 gtk: Fix double-free when OpenGL can't be initialised ... gtk_gl_area_get_error() doesn't return a copy of the error, but just the error. If initialising OpenGL fails, then GtkGstGLWidget will consume the error, and cause GTK to try and display freed memory. ==50914== Invalid read of size 8 ==50914== at 0x4C4CB8A: gtk_gl_area_draw_error_screen (gtkglarea.c:663) ==50914== by 0x4C4CB8A: gtk_gl_area_draw (gtkglarea.c:687) ==50914== by 0x4E061CA: gtk_widget_draw_internal (gtkwidget.c:7084) ==50914== by 0x4BAEFB1: gtk_container_propagate_draw (gtkcontainer.c:3854) ==50914== by 0x4D4B6BF: gtk_stack_render (gtkstack.c:2207) ==50914== by 0x4BB4B03: gtk_css_custom_gadget_draw (gtkcsscustomgadget.c:159) ==50914== by 0x4BBA4C4: gtk_css_gadget_draw (gtkcssgadget.c:885) ==50914== by 0x4D4D780: gtk_stack_draw (gtkstack.c:2119) ==50914== by 0x4E061CA: gtk_widget_draw_internal (gtkwidget.c:7084) ==50914== by 0x4BAEFB1: gtk_container_propagate_draw (gtkcontainer.c:3854) ==50914== by 0x4BAF0C3: gtk_container_draw (gtkcontainer.c:3674) ==50914== by 0x4E061CA: gtk_widget_draw_internal (gtkwidget.c:7084) ==50914== by 0x4BAEFB1: gtk_container_propagate_draw (gtkcontainer.c:3854) ==50914== Address 0x187a0818 is 8 bytes inside a block of size 16 free'd ==50914== at 0x48480E4: free (vg_replace_malloc.c:872) ==50914== by 0x49A5B8C: g_free (gmem.c:218) ==50914== by 0x49C1013: g_slice_free1 (gslice.c:1183) ==50914== by 0x4990DE4: g_error_free (gerror.c:870) ==50914== by 0x4990FE9: g_clear_error (gerror.c:1052) ==50914== by 0x1A489780: _get_gl_context (gtkgstglwidget.c:540) ==50914== by 0x1A4863CB: gst_gtk_invoke_func (gstgtkutils.c:39) ==50914== by 0x49A3834: g_main_context_invoke_full (gmain.c:6137) ==50914== by 0x1A486450: gst_gtk_invoke_on_main (gstgtkutils.c:59) ==50914== by 0x1A48A29E: gtk_gst_gl_widget_init_winsys (gtkgstglwidget.c:632) ==50914== by 0x1A4887E7: gst_gtk_gl_sink_start (gstgtkglsink.c:267) ==50914== by 0x6579810: gst_base_sink_change_state (gstbasesink.c:5662) ==50914== Block was alloc'd at ==50914== at 0x484586F: malloc (vg_replace_malloc.c:381) ==50914== by 0x49A9278: g_malloc (gmem.c:125) ==50914== by 0x49C1BA5: g_slice_alloc (gslice.c:1072) ==50914== by 0x49C3BCC: g_slice_alloc0 (gslice.c:1098) ==50914== by 0x499096B: g_error_allocate (gerror.c:708) ==50914== by 0x4990AF1: UnknownInlinedFun (gerror.c:722) ==50914== by 0x4990AF1: g_error_copy (gerror.c:892) ==50914== by 0x4C4B9F9: gtk_gl_area_set_error (gtkglarea.c:1036) ==50914== by 0x4C4BAF7: gtk_gl_area_real_create_context (gtkglarea.c:346) ==50914== by 0x4B21B28: _gtk_marshal_OBJECT__VOIDv (gtkmarshalers.c:2730) ==50914== by 0x4920B78: UnknownInlinedFun (gclosure.c:893) ==50914== by 0x4920B78: g_signal_emit_valist (gsignal.c:3406) ==50914== by 0x4920CB2: g_signal_emit (gsignal.c:3553) ==50914== by 0x4C4B927: gtk_gl_area_realize (gtkglarea.c:308) Reproduced by running: MESA_GL_VERSION_OVERRIDE=2.7 totem See https://gitlab.gnome.org/GNOME/totem/-/issues/522 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2565>		2022-06-07 17:36:26 +02:00
..
gst-devtools	validate: Fix running as a tracer	2022-06-04 18:04:31 -04:00
gst-docs	Docs: Add the design document for DMA buffer sharing.	2022-06-07 02:28:49 +00:00
gst-editing-services	ges/videourisource: handle non-1/1 PAR source videos	2022-05-17 20:49:30 +00:00
gst-examples	gst-examples: continue if webrtc deps are not satisfied	2022-05-14 09:49:33 +00:00
gst-integration-testsuites	test: update tests to include the new meta	2022-06-03 08:29:05 +00:00
gst-libav	libav: fix frame leak on negotiation error	2022-04-18 07:13:09 +00:00
gst-omx	Use gmodule-no-export-2.0	2022-04-01 16:32:17 +00:00
gst-plugins-bad	va: Update plugin cache.	2022-06-07 12:02:21 +00:00
gst-plugins-base	video: add new video-sei.h header to the list of video_headers	2022-06-03 08:29:05 +00:00
gst-plugins-good	gtk: Fix double-free when OpenGL can't be initialised	2022-06-07 17:36:26 +02:00
gst-plugins-ugly	Always define ENABLE_NLS	2022-04-19 18:01:06 +00:00
gst-python	pythonplugin: fails silently on plugin issue	2022-04-28 08:57:47 +00:00
gst-rtsp-server	rtsp-media: Correct logic on GstRTSPStreamBlocking message reception	2022-05-20 07:37:05 +00:00
gstreamer	basetransform: handle gst_base_transform_query_caps() returning NULL	2022-06-01 09:55:53 +02:00
gstreamer-sharp	gstreamer-sharp: apply new code style to alll sources	2022-04-05 08:28:50 +00:00
gstreamer-vaapi	tests: vaapi: remove unused header	2022-05-27 10:25:20 +00:00
macos-bison-binary
win-flex-bison-binaries
win-nasm
avtp.wrap	subprojects/avtp: Update to latest avtp 0.2.0	2022-03-18 22:49:16 +00:00
bindinator.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
cairo.wrap	meson: Build cairo subproject when unavailable on the system	2022-01-21 06:34:33 +00:00
dav1d.wrap
dssim.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
dv.wrap
expat.wrap	Update wrap files from latest wrapdb version	2022-03-07 17:47:09 +00:00
fdk-aac.wrap	subprojects: fdk-aac: add fallback_url	2021-10-28 23:29:27 +00:00
FFmpeg.wrap	wraps:ffmpeg: Move to 4.4	2021-10-15 02:32:40 +00:00
fontconfig.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
freetype2.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
fribidi.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
gl-headers.wrap	Move files from gst-plugins-base into the "subprojects/gst-plugins-base/" subdir	2021-09-24 16:13:26 -03:00
glib-networking.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
glib.wrap	meson: Update subprojects to fix warnings	2022-01-25 14:25:19 +05:30
graphene.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
gst-plugins-rs.wrap	subprojects: Switch gst-plugins-rs.wrap to the main branch	2022-02-16 09:54:07 +02:00
gtk-sharp.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
harfbuzz.wrap
json-glib.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
lame.wrap	subprojects/lame: Update to latest wrap	2022-01-28 02:01:39 +05:30
libdrm.wrap	meson: Update subprojects to fix warnings	2022-01-25 14:25:19 +05:30
libffi.wrap
libjpeg-turbo.wrap	Update wrap files from latest wrapdb version	2022-03-07 17:47:09 +00:00
libmicrodns.wrap
libnice.wrap	subprojects: Update libnice to 0.1.19	2022-05-03 18:49:36 -04:00
libopenjp2.wrap	Update openjp2 and libxml2 from wrapdb	2022-03-31 14:19:46 -04:00
libpng.wrap	subprojects/libpng: Update to latest wrap file	2022-01-28 02:01:39 +05:30
libpsl.wrap
libsoup.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
libwpe.wrap
libxml2.wrap	Update openjp2 and libxml2 from wrapdb	2022-03-31 14:19:46 -04:00
ogg.wrap	subprojects: Update ogg and vorbis wraps	2021-10-19 17:42:21 +00:00
openh264.wrap	Update openh264 wrap to v2.2.0 + fixes from master	2022-04-09 21:44:42 +01:00
opus.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
orc.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
pango.wrap
pcre.wrap	subprojects/pcre: Add the wrap so it's cached in the image	2022-01-28 02:01:39 +05:30
pixman.wrap	meson: Update subprojects to fix warnings	2022-01-25 14:25:19 +05:30
proxy-libintl.wrap	Update proxy-libintl wrap to 0.4	2022-04-22 15:36:40 +00:00
pycairo.wrap
pygobject.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
sqlite3.wrap	Update wrap files from latest wrapdb version	2022-03-07 17:47:09 +00:00
vorbis.wrap	subprojects: Update ogg and vorbis wraps	2021-10-19 17:42:21 +00:00
webrtc-audio-processing.wrap	Pin all wrap files to closest tag or commit sha1	2021-10-14 22:34:49 +00:00
wpebackend-fdo.wrap
x264.wrap
zlib.wrap	Update wrap files from latest wrapdb version	2022-03-07 17:47:09 +00:00