mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-24 18:51:11 +00:00
5b8d7a443e
Allows callers to properly reference count the buffers used for rendering. Fixes a redraw race in glimagesink where the previous buffer (the one used for redraw operations) is freed as soon as the next buffer is uploaded. 1. glimagesink uploads in _prepare() to texture n 1.1 glupload holds buffer n 2. glimagesink _render()s texture n 3. glimagesink uploads texture n+1 3.1 glupload free previous buffer which deletes texture n 3.2 glupload holds buffer n+1 4. glwindow resize/expose 5. glimagesink redraws with texture n The race is that the buffer n (the one used for redrawing) is freed as soon as the buffer n+1 arrives. There could be any amount of time and number of redraws between this event and when buffer n+1 is actually rendered and thus replaces buffer n as the redraw source. https://bugzilla.gnome.org/show_bug.cgi?id=736740
90 lines
2.8 KiB
C
90 lines
2.8 KiB
C
/*
|
|
* GStreamer
|
|
* Copyright (C) 2012 Matthew Waters <ystree00@gmail.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#ifndef __GST_GL_UPLOAD_H__
|
|
#define __GST_GL_UPLOAD_H__
|
|
|
|
#include <gst/video/video.h>
|
|
#include <gst/gstmemory.h>
|
|
|
|
#include <gst/gl/gstgl_fwd.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
GType gst_gl_upload_get_type (void);
|
|
#define GST_TYPE_GL_UPLOAD (gst_gl_upload_get_type())
|
|
#define GST_GL_UPLOAD(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_GL_UPLOAD,GstGLUpload))
|
|
#define GST_GL_UPLOAD_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass),GST_TYPE_GL_UPLOAD,GstGLUploadClass))
|
|
#define GST_IS_GL_UPLOAD(obj) (G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_GL_UPLOAD))
|
|
#define GST_IS_GL_UPLOAD_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_GL_UPLOAD))
|
|
#define GST_GL_UPLOAD_CAST(obj) ((GstGLUpload*)(obj))
|
|
|
|
/**
|
|
* GstGLUpload
|
|
*
|
|
* Opaque #GstGLUpload object
|
|
*/
|
|
struct _GstGLUpload
|
|
{
|
|
/* <private> */
|
|
GstObject parent;
|
|
|
|
GstGLContext *context;
|
|
GstGLColorConvert *convert;
|
|
|
|
/* input data */
|
|
GstVideoInfo in_info;
|
|
|
|
gboolean initted;
|
|
|
|
GstGLMemory *in_tex[GST_VIDEO_MAX_PLANES];
|
|
GstGLMemory *out_tex;
|
|
|
|
/* <private> */
|
|
GstGLUploadPrivate *priv;
|
|
|
|
gpointer _reserved[GST_PADDING];
|
|
};
|
|
|
|
/**
|
|
* GstGLUploadClass:
|
|
*
|
|
* The #GstGLUploadClass struct only contains private data
|
|
*/
|
|
struct _GstGLUploadClass
|
|
{
|
|
GstObjectClass object_class;
|
|
};
|
|
|
|
GstGLUpload * gst_gl_upload_new (GstGLContext * context);
|
|
|
|
void gst_gl_upload_set_format (GstGLUpload * upload, GstVideoInfo * in_info);
|
|
GstVideoInfo * gst_gl_upload_get_format (GstGLUpload * upload);
|
|
|
|
gboolean gst_gl_upload_perform_with_buffer (GstGLUpload * upload, GstBuffer * buffer, guint * tex_id, GstBuffer ** outbuf);
|
|
void gst_gl_upload_release_buffer (GstGLUpload * upload);
|
|
gboolean gst_gl_upload_perform_with_data (GstGLUpload * upload, GLuint * texture_id,
|
|
gpointer data[GST_VIDEO_MAX_PLANES], GstBuffer ** outbuf);
|
|
|
|
gboolean gst_gl_upload_perform_with_gl_texture_upload_meta (GstGLUpload *upload, GstVideoGLTextureUploadMeta *meta, guint texture_id[4], GstBuffer ** outbuf);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __GST_GL_UPLOAD_H__ */
|